add libplist #5242
add libplist #5242
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| def build(self): | ||
| cmake = self._configure_cmake() | ||
| cmake.build() |
There was a problem hiding this comment.
I know it's a pain on Windows, but this project provides autotools files. Do your properly emulate what happen in upstream configure.ac and Makefile.am?
There was a problem hiding this comment.
Autotools is hard to cross-platform compilation. so I do not try it. This CMakeLists.txt is uesd to compile libplist in my project for two years and it work well, so I just take it and use it.
| url: "https://github.com/libimobiledevice-win32/libplist/archive/refs/tags/v1.2.240.tar.gz" | ||
| sha256: "9de6e5b8cb806e4cde96ef68833fe6baba0094a12072db343e9c2fdd52187e9e" | ||
| "1.3.17": | ||
| url: "https://github.com/libimobiledevice-win32/libplist/archive/refs/tags/v1.3.17.tar.gz" |
There was a problem hiding this comment.
https://github.com/libimobiledevice-win32/libplist is a fork of https://github.com/libimobiledevice/libplist, which one is official repo now?
There was a problem hiding this comment.
https://github.com/libimobiledevice/libplist is the officail repo but it is fail to build under windows. https://github.com/libimobiledevice-win32/libplist fix these compile error.
There was a problem hiding this comment.
Why not provide a patch to upstream instead? You should use Official release: https://github.com/conan-io/conan-center-index/blob/master/docs/faqs.md#what-version-should-packages-use-for-libraries-without-official-releases
There was a problem hiding this comment.
libimobiledevice/libplist#76 This is the pull request submitted by the owner of https://github.com/libimobiledevice-win32/libplist. It is about 5 years old yet hasn't been merged.
There was a problem hiding this comment.
Upstream rebased the PR but never answered xD
There was a problem hiding this comment.
I tried to use official repo and it is failed to build as expected. I also try to make patch for official source, but the change is too much. The patch file generated by git has more than 3000 lines. I am very worried about that this patch will conflict with official new release.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This reverts commit 30ebd57.
Specify library name and version: libplist/1.2.240, libplist/1.3.17
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
It is a dependency of my project.
conan-center hook activated.