Patch macdeployqt

[MartinDelille]

Specify library name and version: qt/5.15.2

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

fix #5487

[Minimonium]

From the visible design perspective - I think it'd be better to fill the pluginPath from the shared.cpp, at the same place as the qtPath.
Then, here you'd need to only check that !deploymentInfo.pluginPath.isEmpty().

[ericLemanissier]

Thanks ! Could you please report the bug at bugreports.qt.io, and submit the patch for review at codereview.qt.io ?

[MartinDelille]

The issue has already been adressed here: qt/qttools@03abcba

Shall I generate the patch from this commit instead ?

Do we agree that the CI failure has nothing to do with my change ?

[Minimonium]

Shall I generate the patch from this commit instead?

That would be ideal.

[MartinDelille]

Unfortunately, the patch doesn't apply correctly, probably due to the fact that other commits have modified the file:

git log --oneline v5.15.2..dev src/macdeployqt/macdeployqt/main.cpp
03abcbabb macdeployqt: Fix plugin resolution bugs for non-standard installs
e6ad15080 Merge remote-tracking branch 'origin/5.15' into dev
b2f3eb655 Merge remote-tracking branch 'origin/5.15' into dev
6b2f32f3d Fix Qt6 build

[MartinDelille]

@ericLemanissier I fixed the patch because it looks like the QLibraryInfo class changed in Qt 6:

• qt5: https://doc.qt.io/qt-5/qlibraryinfo.html#location
• qt6: https://doc.qt.io/qt-6/qlibraryinfo.html#path

Should I submit a patch to the 5.15 branch ?

[conan-center-bot]

All green in build 3 (15b4572ceb551183f3d4c115028bb1e07fdbf9d5):

• qt/5.15.2@:
  All packages built successfully! (All logs)

[ghost]

I detected other pull requests that are modifying qt/5.x.x recipe:

• Qt: add component support for Qt5 #5691

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[MartinDelille]

Is there missing for this PR to be accepted ?

[prince-chrismc]

My only question is will there be another 5.x.x release that will include this fix in the near future?

If no, I'll approve 🙃

[wdobbe]

@prince-chrismc Qt company has announced that updates to qt 5.15 will only available to commercial customers. So it is not very likely that we will get a new 5.x release. Although I think KDE maintains a Qt 5.15 fork with patches.