Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the marked-up object compiler, moc, package to conan center #5832
add the marked-up object compiler, moc, package to conan center #5832
Changes from all commits
7867567
567a96c
2aff6f3
7b91d2a
3baf2ec
dc45d53
4f6966e
265ab70
7e5e9a4
0ddbe72
801fae2
c7bd94c
52b1913
ba695a6
0e8071b
30a4a98
7aaff90
cdfd621
04370c7
350e450
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I see in installation layout:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those folders contain CMake target files, they shouldn't be packaged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it test link to
uf
library? It's the only one I see underlib/uf
folder. Since this folder was not added to ofcpp_info.libdirs
, I'm wondering ifcpp_info.libs
is not empty...Why upstream CMakeLists install this library in this subfolder instead of
lib
folder directly?