Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add effcee recipe #6133

Merged
merged 19 commits into from
Jul 26, 2021
Merged

add effcee recipe #6133

merged 19 commits into from
Jul 26, 2021

Conversation

AndreyMlashkin
Copy link
Contributor

@AndreyMlashkin AndreyMlashkin commented Jul 2, 2021

Specify library name and version: effcee/v2019.1@

this lib is needed for creation a recipe for https://github.com/microsoft/DirectXShaderCompiler

closes #6128


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

recipes/effcee/all/conanfile.py Outdated Show resolved Hide resolved
recipes/effcee/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/effcee/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

Do someone have a clue, why mac-clang complains about the test package?

the enum is declared like:

namespace effcee {
...
class Result {
public:
enum class Status {
Ok = 0,
Fail, // A failure to match
BadOption, // A bad option was specified
NoRules, // No rules were specified
BadRule, // A bad rule was specified
};
...

Test code:

auto result = effcee::Match(input_stream.str(), checks_stream.str(),
effcee::Options().SetChecksName("checks"));

// Successful match result converts to true.
if (result) {
std::cout << "The input matched your check list!" << std::endl;
} else {
// Otherwise, you can get a status code and a detailed message.
switch (result.status()) {
case effcee::Result::Status::NoRules:
std::cout << "error: Expected check rules as command line arguments\n";
break;
case effcee::Result::Status::Fail:
std::cout << "The input failed to match your check rules:\n";
break;
default:
break;
}

/Users/jenkins/w/BuildSingleReference@2/conan-center-index/recipes/effcee/all/test_package/main.cc:54:12: error: expression is not an integral constant expression
case effcee::Result::Status::Fail:

@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

What is the best way to force compiler to use at least cpp11 (the higher, the better)?

@prince-chrismc
Copy link
Contributor

What is the best way to force compiler to use at least cpp11 (the higher, the better)?

conan-io/conan#8002 is my go to

@uilianries
Copy link
Member

What is the best way to force compiler to use at least cpp11 (the higher, the better)?

https://github.com/conan-io/conan-center-index/blob/master/recipes/easyhttpcpp/all/CMakeLists.txt#L8

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

Why windows runtime for test package is not taken from conan?...

@prince-chrismc
Copy link
Contributor

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

If I try to reproduce the problem from the CI, I am fetting a different error... does anyone have a clue?

build_log.txt

@AndreyMlashkin
Copy link
Contributor Author

Ah, I see, I have compiler version 16, not 14.
So, I have the same issue - I've got a *.dll instrad of an *.a file...
Why flag from conan is not applied?

@prince-chrismc
Copy link
Contributor

@AndreyMlashkin The install is incorrect https://github.com/google/effcee/blob/2ec8f8738118cc483b67c04a759fee53496c5659/effcee/CMakeLists.txt#L16

It's missing runtime for the DLL/shared

@AndreyMlashkin
Copy link
Contributor Author

Not sure, what should I change there

@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

I don't know, what happened to PR, I needed to rebase and force push.

@conan-center-bot
Copy link
Collaborator

All green in build 22 (e28e98f7fdeca22368b3d23e71fd192f56f28089):

  • effcee/2019.1@:
    All packages built successfully! (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] effcee/2019.1
5 participants