OpenSSL on Windows: multi-profile support #6337

stefan-floeren · 2021-07-14T15:04:19Z

Specify library name and version: openssl/1.x.x

Using different profiles for build and host (pr:b and pr:h) leads to an error when using OpenSSL:

ERROR: openssl/1.1.1k: Error in build() method, line 709
        env_vars = {"PERL": self._perl}
while calling '_perl', line 630
        return os.path.join(self.deps_cpp_info["strawberryperl"].rootpath, "bin", "perl.exe")
        KeyError: 'strawberryperl'

This is due to assuming deps_cpp_info is always available. As documented this is only true for packages on the host context, while strawberryperl is in the "build" context .

This change modifies strawberryperl to also set the user_info and then use this value in openssl, if a multi-profile build is used.

Depends on #6338 for multi-profile.

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

recipes/strawberryperl/all/conanfile.py

… to an error when using _OpenSSL_: ``` ERROR: openssl/1.1.1k: Error in build() method, line 709 env_vars = {"PERL": self._perl} while calling '_perl', line 630 return os.path.join(self.deps_cpp_info["strawberryperl"].rootpath, "bin", "perl.exe") KeyError: 'strawberryperl' ``` This is due to assuming `deps_cpp_info` is always available. As [documented](https://docs.conan.io/en/1.36/reference/conanfile/attributes.html#deps-user-info) this is only true for packages on the host context, while _strawberryperl_ is in the "build" context . This change modifies _OpenSSL_, so it can be used in both ways.

conan-center-bot · 2021-07-15T08:30:17Z

All green in build 2 (0eaa1bc4b0ff4d9effcc5d03d5927210e2ac7589):

openssl/1.0.2s@:
All packages built successfully! (All logs)
openssl/1.0.2t@:
All packages built successfully! (All logs)
openssl/1.0.2u@:
All packages built successfully! (All logs)
openssl/1.1.0k@:
All packages built successfully! (All logs)
openssl/1.1.0l@:
All packages built successfully! (All logs)
openssl/1.1.1c@:
All packages built successfully! (All logs)
openssl/1.1.1d@:
All packages built successfully! (All logs)
openssl/1.1.1e@:
All packages built successfully! (All logs)
openssl/1.1.1k@:
All packages built successfully! (All logs)
openssl/1.1.1f@:
All packages built successfully! (All logs)
openssl/1.1.1g@:
All packages built successfully! (All logs)
openssl/1.1.1h@:
All packages built successfully! (All logs)
openssl/1.1.1i@:
All packages built successfully! (All logs)
openssl/1.1.1j@:
All packages built successfully! (All logs)

SSE4 · 2021-07-20T05:50:37Z

@uilianries why blocked?

…upport Co-Authored-By: Stefan Floeren <stefan-floeren@users.noreply.github.com>

@syoliver

* openssl: create 3.x.x directory * openssl/3.x.x: Update license to Apache-2.0 * openssl/3.x.x: Update reporting issues URL * openssl/3.x.x: Add no_deprecated, no_legacy and no_fips options * openssl/3.x.x: Delete patch for 1.1.1 * openssl/3.x.x: Update option from no_zlib to zlib * openssl/3.x.x: Remove removed options no_md2 and no_rc5 * openssl/3.x.x.: no_rc4 is still a valid option https://github.com/openssl/openssl/blob/1b495200436b57309ca958a7a72affaf75171c1a/INSTALL.md#no-algorithm * openssl/3.x.x: Remove legacy target names * openssl/3.x.x.: Remove more legacy conditions * openssl/3.x.x: Fix zlib option name * Revert "openssl/3.x.x: Update license to Apache-2.0" This reverts commit 13852ab1da9678d3700440bee862561af7878b37. * openssl/3.x.x: Actually update license to Apache-2.0 * openssl/3.x.x.: Remove all legacy version switches * openssl/3.x.x: Use OpenSSL_version instead of legacy SSLeay_version * openssl/3.x.x.: update test_package to never use find_package() Several reasons for this decision: 1) No matter the value of the paramter use_find_package CMake did always use a FindOpenSSL.cmake file 2) On my machine that meant that CMake used a FindOpenSSL.cmake file from my Python installation, which can't yet handle version 3.0.0 due to a regex error 3) Even when I addded the Conan cmake_find_package generator, it did not work (more cpp_info work needed, maybe?) 4) Even when 3) would be fixed, it would still always use the FindOpenSSL.cmake approach for some reason (I guess), so the entire use_find_package switch is pointless * openssl/3.x.x.: Remove custom OpenSSLVersion object * openssl/3.x.x.: Remove legacy target_prefix * openssl/3.x.x.: Remove custom _cross_building method Since tools.cross_building() has now a skip_x64_x86 flag * openssl/3.x.x: Some formatting * openssl/3.x.x: Remove old workaround for MinGW This got fixed in the meantime via openssl/openssl@9694ebf See also openssl/openssl#7653 * openssl/3.x.x: add no_engine option * openssl/3.x.x: Add 3.0.0-alpha5 * openssl/3.x.x: Port #1782 from @syoliver - add components * openssl/3.x.x: Fix license test The LICENSE file got renamed to LICENSE.txt * openssl/3.x.x: add old/ URLs as mirrors * openssl/3.x.x: threat URLs explicit as strings * openssl/3.x.x: add 3.0.0-alpha6 * openssl/3.x.x: the downloads have permament locations now This seems to be the case for a while now, but not for all old versions we support in the recipe for the 1.x.x versions It also does not seem to apply for pre-release versions, which rather seem to get de-published See also here: openssl/openssl#4469 * openssl: Update Conan conventions Automatically created by bincrafters-conventions 0.26.0 * openssl/3.x.x: reorder methods * openssl/3.x.x: add 3.0.0-alpha7 * openssl/3.x.x: test upstream PR 13225 openssl/openssl#13225 * openssl/3.x.x: update patch from upstream PR13225 * openssl/3.x.x: port #2944 Require installation of msys2 for MinGW builds * openssl/3.x.x: port #3214 fix openssl/** build with shared and fPIC option for OS Neutrino * openssl/3.x.x: add 3.0.0-alpha8 * openssl/3.x.x: remove fPIC when shared Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: add 3.0.0-alpha9 * openssl/3.x.x: use get_safe for fPIC * openssl/3.x.x: don't use get_safe for zlib option Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: add 3.0.0-alpha10 * openssl/3.x.x: add openssl/3.0.0-alpha11 * openssl: Update Conan conventions Automatically created by bincrafters-conventions 0.30.2 * openssl/3.x.x: add openssl/3.0.0 * openssl: Update Conan conventions Automatically created by bincrafters-conventions 0.30.5 * openssl/3.x.x: modernize Co-Authored-By: Anonymous Maarten <anonymous.maarten@gmail.com> * openssl/3.x.x: modernize Co-Authored-By: Anonymous Maarten <anonymous.maarten@gmail.com> * openssl/3.x.x: replace os.rename -> tools.rename * opeensl/3.x.x.: nit Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: readd old versions to config.yml Co-Authored-By: Anonymous Maarten <anonymous.maarten@gmail.com> * openssl/3.x.x: remove platform import Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: fix typo in option name * openssl/3.x.x: more tools modernizations * openssl/3.x.x: use textwrap Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: remove MD5 and SHA1 from test_package * openssl/3.x.x: use self.options.get_safe() * openssl: add openssl.pc + fix libdir * openssl: convert test to pure C source * openssl: use spaces in test source * openssl/3.x.x: remove SSL_library_init from test_package * openssl: run openssl binary in test package * openssl: digest.c only needs crypto library * openssl: remove unused definitions for cmake * openssl: enable fPIC when not enabled + use zlib's shared option correctly * openssl: don't echo args (there is log.print_run_commands) + don't add shared/zlib multiple times * openssl: tools.XCRun only acceps Settings object * openssl: use self.settings.os * openssl: reformatting + be the first to use f-strings + functools.lru_cache * openssl: ./Configure --help does not print any targets. * openssl: fix critical typo * openssl: fix sneaky usage of tools.os_info in build_requirements * openssl/3.x.x: remove patch for macOS shared Co-Authored-By: Bowb <bowb@users.noreply.github.com> * openssl/3.x.x: port #4460 remove explicit apple deployment target flag Co-Authored-By: SSE4 <tomskside@gmail.com> * openssl/3.x.x: port #4597 provide official variables in cmake_find_package Co-Authored-By: SpaceIm <spaceim@users.noreply.github.com> * openssl/3.x.x: port #4698 fix rt dependency for SUSE11 Co-Authored-By: Alexey Klimkin <klimkin@gmail.com> * openssl/3.x.x: port #4772 fix builddirs and add vars module to cmake_find_package only Co-Authored-By: SpaceIm <spaceim@users.noreply.github.com> * openssl/3.x.x: port #5441 closes #4740 Co-Authored-By: Dmitry Bely <db4@users.noreply.github.com> * openssl/3.x.x: port #3998 add libatomic in build dependency for Neutrino OS Co-Authored-By: Arenoros <arenoros@users.noreply.github.com> * openssl/3.x.x: port #6337 OpenSSL on Windows: multi-profile support Co-Authored-By: Stefan Floeren <stefan-floeren@users.noreply.github.com> * openssl/3.x.x: port #6588 Add macOS ARM target Co-Authored-By: gmeeker <gmeeker@users.noreply.github.com> * openssl/3.x.x: port #6884 Build openssl for emscripten Co-Authored-By: Volodymyr B. <3d4m-vladimir@users.noreply.github.com> * openssl: reformatting fixes * openssl: make method property + remove unused import * openssl: reverse sort openssl's config.yml * openssl: only run openssl when not cross building * openssl: port options of openssl 1.1.1 * openssl: fix MSVC install + remove options unsupported by openssl 3 + openssl exe is only available when building with no_stio=False * force push Signed-off-by: Uilian Ries <uilianries@gmail.com> * openssl: add missing options + various reformatting Co-authored-by: bincrafters-user <bincrafters@gmail.com> Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> Co-authored-by: Anonymous Maarten <anonymous.maarten@gmail.com> Co-authored-by: Bowb <bowb@users.noreply.github.com> Co-authored-by: SSE4 <tomskside@gmail.com> Co-authored-by: SpaceIm <spaceim@users.noreply.github.com> Co-authored-by: Alexey Klimkin <klimkin@gmail.com> Co-authored-by: Dmitry Bely <db4@users.noreply.github.com> Co-authored-by: Arenoros <arenoros@users.noreply.github.com> Co-authored-by: Stefan Floeren <stefan-floeren@users.noreply.github.com> Co-authored-by: gmeeker <gmeeker@users.noreply.github.com> Co-authored-by: Volodymyr B. <3d4m-vladimir@users.noreply.github.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>

stefan-floeren commented Jul 14, 2021

View reviewed changes

recipes/strawberryperl/all/conanfile.py Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jul 14, 2021

ghost mentioned this pull request Jul 14, 2021

[service] Potentially conflicting recipes #3571

Closed

stefan-floeren force-pushed the openssl-multi-profile branch from a0aae66 to 0eaa1bc Compare July 14, 2021 15:13

stefan-floeren mentioned this pull request Jul 14, 2021

Add user_info to strawberryperl #6338

Merged

4 tasks

conan-center-bot removed the Failed label Jul 15, 2021

conan-center-bot requested a review from SSE4 July 15, 2021 12:00

SSE4 requested a review from uilianries July 18, 2021 07:25

SSE4 approved these changes Jul 18, 2021

View reviewed changes

github-actions bot mentioned this pull request Jul 18, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

prince-chrismc approved these changes Jul 18, 2021

View reviewed changes

conan-center-bot requested a review from czoido July 19, 2021 11:57

uilianries added the blocked Affected by an external issue and waiting until it is solved label Jul 19, 2021

conan-center-bot requested a review from danimtb July 21, 2021 11:58

danimtb approved these changes Jul 21, 2021

View reviewed changes

conan-center-bot merged commit 4aaee5b into conan-io:master Jul 21, 2021

Croydon added a commit to bincrafters/conan-center-index that referenced this pull request Sep 9, 2021

openssl/3.x.x: port conan-io#6337 OpenSSL on Windows: multi-profile s…

2a989ed

…upport Co-Authored-By: Stefan Floeren <stefan-floeren@users.noreply.github.com>

stefan-floeren deleted the openssl-multi-profile branch August 16, 2023 09:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OpenSSL on Windows: multi-profile support #6337

OpenSSL on Windows: multi-profile support #6337

stefan-floeren commented Jul 14, 2021 •

edited

Loading

This comment has been minimized.

conan-center-bot commented Jul 15, 2021

SSE4 commented Jul 20, 2021

OpenSSL on Windows: multi-profile support #6337

OpenSSL on Windows: multi-profile support #6337

Conversation

stefan-floeren commented Jul 14, 2021 • edited Loading

Depends on #6338 for multi-profile.

This comment has been minimized.

conan-center-bot commented Jul 15, 2021

SSE4 commented Jul 20, 2021

stefan-floeren commented Jul 14, 2021 •

edited

Loading