Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[changelog] Enable M1 builds (and more things) #6658

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Aug 3, 2021

Some words about the biggest change here:

  • [feature] BuildSingleReference: Create packages for apple-clang armv8 (Apple M1) in pull-requests' builds.

    It's been a while since we started to think about M1 configurations in ConanCenter. During this time we have implemented the changes required in the CI library and, mostly, we have tried to prepare as many recipes as possible for this new configuration (special thanks to @SSE4 and @SpaceIm).

    This configuration is not only new by itself, but it is the first one that uses two profiles (--profile:host and --profile:build) to create the binaries. We are cross-compiling from a regular Macos (x64) to ARM architecture, so be aware, some builds and libraries might become challenging.

    It is expected (sorry in advance) that some PRs will start to fail. We have tried our best, but it is impossible for us alone to keep the pace and fix all the recipes at the time they are being added. Expected errors could be:

    • Missing dependencies: if any of the dependencies is not already available, the PR will fail with that message. To fix it, a PR to the offending library must be created. We understand you might be focused only on the consumer library, we'll try to be proactive, but feel free to mention any of us and we will take care of fixing the dependency for you.
    • Errors for M1 configuration: it's very likely that a library (or even a PR that was opened before this change) was working and now M1 configuration fails. This error probably is not related to the changes in your PR, it is just that the library was not working before. We would love it if you can fix this configuration, I'm sure reviewers will help, but if you prefer to keep your PR simpler it is ok if you just raise a ConanInvalidConfiguration for that configuration and the CI will skip the build.
    • Unexpected errors: ... well, these are unexpected, ping us and we will have a look at them.

@conan-center-bot

This comment has been minimized.

@jgsogo jgsogo changed the title [changelog] Enable M1 builds (and others) [changelog] Enable M1 builds (and more things) Aug 3, 2021
@conan-center-bot
Copy link
Collaborator

Updating docs!

@SSE4 SSE4 requested a review from uilianries August 3, 2021 13:49
@conan-center-bot conan-center-bot merged commit cc9a172 into conan-io:master Aug 3, 2021
This was referenced Aug 4, 2021
@jgsogo
Copy link
Contributor Author

jgsogo commented Aug 5, 2021

After these changes I would have expected a PR to modify this doc file https://github.com/conan-io/conan-center-index/blob/master/docs/supported_platforms_and_configurations.md, removing duplicated in lists and ordering the versions properly... 🤔 Need to review those changes.

@jgsogo jgsogo deleted the changelog branch August 5, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants