openssl-3.x.x: Migrating names and build_modules to set_property format
#8059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Croydon
approved these changes
Nov 15, 2021
madebr
approved these changes
Nov 15, 2021
|
All green in build 1 (
|
SSE4
approved these changes
Nov 18, 2021
SpaceIm
reviewed
Nov 18, 2021
| self.cpp_info.names["cmake_find_package"] = "OpenSSL" | ||
| self.cpp_info.names["cmake_find_package_multi"] = "OpenSSL" | ||
| self.cpp_info.names["pkg_config"] = "openssl" | ||
| self.cpp_info.set_property("cmake_target_name", "OpenSSL") |
There was a problem hiding this comment.
You have forgotten cmake_file_name, now it generates Findopenssl.cmake instead of FindOpenSSL.cmake. Therefore test package uses built-in FindOpenSSL.cmake from CMake installation instead of conan generated one.
4 tasks
ivanvurbanov
pushed a commit
to ivanvurbanov/conan-center-index
that referenced
this pull request
Dec 2, 2021
…to `set_property` format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: openssl/3.x.x
conan-center hook activated.