Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openblas] Expose additional options #855

Merged
merged 3 commits into from
Mar 2, 2020
Merged

[openblas] Expose additional options #855

merged 3 commits into from
Mar 2, 2020

Conversation

pleroux0
Copy link
Contributor

Add use_thread option to set USE_THREAD
Add dynamic_arch option to set DYNAMIC_ARCH

Specify library name and version: openblas/0.3.7

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

Add use_thread option to set USE_THREAD
Add dynamic_arch option to set DYNAMIC_ARCH
@claassistantio
Copy link

claassistantio commented Feb 13, 2020

CLA assistant check
All committers have signed the CLA.

@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

@pleroux0
Copy link
Contributor Author

How long does it usually take to be added to the early access program? Can someone else with permissions start the build or must we wait till I am part of the early access program?

uilianries
uilianries previously approved these changes Feb 20, 2020
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pleroux0 thanks for your contribution. Let's wait EAP approval. It can take some days.

@@ -46,6 +50,12 @@ def _configure_cmake(self):

cmake.definitions["NOFORTRAN"] = not self.options.build_lapack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're modifying this recipe, can you add caching to cmake to avoid reconfiguration for package after build?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be great.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the script to avoid unnecessary re-configuration.

While making the update, I noticed an inconsistency in the CMake build helper parameter naming: configure takes a build_folder parameter, but install takes a build_dir parameter.

Copy link
Contributor

@madebr madebr Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build() has also a build_dir argument. I guess it is to override build_folder, given as an argument to configure().
Not that the build_dir argument of configure is deprecated

@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

@conan-center-bot
Copy link
Collaborator

All green in build 4 (c905fd85c11cc1b8f76177a17de8f1d09d12dbd6)! 😊

@danimtb danimtb requested review from uilianries and SSE4 March 2, 2020 11:48
@SSE4 SSE4 removed the request for review from uilianries March 2, 2020 11:49
@danimtb danimtb self-assigned this Mar 2, 2020
@danimtb danimtb merged commit 536cbe6 into conan-io:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants