-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openblas] Expose additional options #855
Conversation
Add use_thread option to set USE_THREAD Add dynamic_arch option to set DYNAMIC_ARCH
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
How long does it usually take to be added to the early access program? Can someone else with permissions start the build or must we wait till I am part of the early access program? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pleroux0 thanks for your contribution. Let's wait EAP approval. It can take some days.
@@ -46,6 +50,12 @@ def _configure_cmake(self): | |||
|
|||
cmake.definitions["NOFORTRAN"] = not self.options.build_lapack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're modifying this recipe, can you add caching to cmake to avoid reconfiguration for package after build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the script to avoid unnecessary re-configuration.
While making the update, I noticed an inconsistency in the CMake build helper parameter naming: configure takes a build_folder parameter, but install takes a build_dir parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build()
has also a build_dir
argument. I guess it is to override build_folder
, given as an argument to configure()
.
Not that the build_dir
argument of configure
is deprecated
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
All green in build 4 (
|
Add use_thread option to set USE_THREAD
Add dynamic_arch option to set DYNAMIC_ARCH
Specify library name and version: openblas/0.3.7
conan-center hook activated.