Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libqrencode/4.0.0 recipe #863

Merged
merged 2 commits into from
Mar 2, 2020
Merged

Add libqrencode/4.0.0 recipe #863

merged 2 commits into from
Mar 2, 2020

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Feb 13, 2020

Specify library name and version: libqrencode/4.0.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'libqrencode/4.0.0' failed in build 1 (4414d017a0be3cfd655da1d81e54258b0dfd1a31):

@conan-center-bot
Copy link
Collaborator

All green in build 2 (ee4f40d46f12faff414a1548a2f09031cb730103)! 😊

uilianries
uilianries previously approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license is not dual. Anyway, this recipe is good enough

recipes/libqrencode/all/conanfile.py Outdated Show resolved Hide resolved
SSE4
SSE4 previously approved these changes Feb 13, 2020
View reviewed changes
@madebr @uilianries
libqrencode: fix license
3a9ee31 
Co-Authored-By: Uilian Ries <uilianries@gmail.com>
@madebr madebr dismissed stale reviews from SSE4 and uilianries via 3a9ee31 February 13, 2020 19:10
@conan-center-bot
Copy link
Collaborator

All green in build 3 (33c5817e2d941abf2b71e5034d08c3877b980760)! 😊

@uilianries uilianries mentioned this pull request Feb 13, 2020
Merged
4 tasks
SSE4
SSE4 approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful

@madebr
Copy link
Contributor Author

madebr commented Feb 22, 2020

@danimtb Please give final review and merge ☺️

@SpaceIm SpaceIm mentioned this pull request Feb 28, 2020
Closed
@danimtb danimtb self-assigned this Mar 2, 2020
@danimtb danimtb merged commit 70178f6 into conan-io:master Mar 2, 2020
@madebr madebr deleted the libqrencode branch March 2, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb danimtb approved these changes

@uilianries uilianries uilianries approved these changes

@SSE4 SSE4 SSE4 approved these changes

Assignees

@danimtb danimtb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@madebr @conan-center-bot @SSE4 @uilianries @danimtb