-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onetbb: support versions of deprecated tbb recipe #9164
onetbb: support versions of deprecated tbb recipe #9164
Conversation
0dcc8b1
to
35f8567
Compare
This comment has been minimized.
This comment has been minimized.
tbb recupe is deprecated, all versions which were supported in tbb recipe are backported to onetbb recipe
35f8567
to
c942b84
Compare
This comment has been minimized.
This comment has been minimized.
? It builds fine for me on Ubuntu with gcc11, same profile. |
This comment has been minimized.
This comment has been minimized.
@jgsogo What's wrong in this agent? Can't reproduce this error on Ubuntu with gcc11. |
maybe |
Hi. I'm far from being an expert in Kubernetes, but as it happened with some other library some month ago, it looks like not everything depends on the docker image, but also on the underlying machine running docker. Those Linux machines are not under our control, so probably this is something that we cannot change and, if it is relatively new instruction, probably it's still not available (I assume the vendor is continuously upgrading its machines, but cannot confirm this point) |
I don't think it's about actual CPU in k8s cluster supporting execution of TSX-NI and tpause instruction, it's about binutils (GNU assembler) doesn't know the opcode (binary representation) of tpause instruction and cannot produce binary. |
Thanks a lot for that master class! 🤟 |
ok, let's just add old versions and see if it works |
This comment has been minimized.
This comment has been minimized.
All green in build 6 (
|
@prince-chrismc @ericLemanissier @toge @madebr one last review please? So that we can start to update recipes depending on |
Sorry for being slow! new job == busy 😭 trying to make more time to review PRs I promise ❤️ |
As suggested in #8308, and implemented in #9162, this PR assumes that we agree to deprecate tbb recipe.
All versions which were supported in tbb recipe are backported to onetbb recipe.
closes #8308
conan-center hook activated.