Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl 1.x.x: modernize #9208

Merged
merged 6 commits into from
Feb 7, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 31, 2022


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

this patch has probably never been tested properly in all versions it claimed to support
@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Feb 1, 2022

@jgsogo

cmake/3.22.0: Not found in local cache, looking in remotes...
cmake/3.22.0: Trying with 'conan-center'...
Downloading conanmanifest.txt
Downloading conanfile.py
Downloading conan_export.tgz
cmake/3.22.0: Downloaded recipe revision 0f16d40d1712f40dedf01cadc2377b9c
openssl/1.1.1m: Not found in local cache, looking in remotes...
openssl/1.1.1m: Trying with 'conan-center'...
Downloading conanmanifest.txt
Downloading conanfile.py
Downloading conan_export.tgz
openssl/1.1.1m: Downloaded recipe revision baa265ba7a1c1bdf33346264aa84fa43
ERROR: openssl/1.1.1m: option 'no_md2' doesn't exist
Possible options are ['no_threads', 'shared', 'fPIC', 'no_asm', 'enable_weak_ssl_ciphers', '386', 'no_stdio', 'no_tests', 'no_sse2', 'no_bf', 'no_cast', 'no_des', 'no_dh', 'no_dsa', 'no_hmac', 'no_md5', 'no_mdc2', 'no_rc2', 'no_rsa', 'no_sha', 'no_async', 'no_dso', 'no_aria', 'no_blake2', 'no_camellia', 'no_chacha', 'no_cms', 'no_comp', 'no_ct', 'no_deprecated', 'no_dgram', 'no_engine', 'no_filenames', 'no_gost', 'no_idea', 'no_md4', 'no_ocsp', 'no_pinshared', 'no_rmd160', 'no_sm2', 'no_sm3', 'no_sm4', 'no_srp', 'no_srtp', 'no_ssl', 'no_ts', 'no_whirlpool', 'no_ec', 'no_ecdh', 'no_ecdsa', 'no_rfc3779', 'no_seed', 'no_sock', 'no_ssl3', 'no_tls1', 'openssldir']

cmake is in build requirements of test package, which drags openssl/1.1.1m. Why does it complain about no_md2 option (this option is deleted if openssl >= 1.1.0) ? It's an option part of the host profile (openssl/1.0.2t), not the build profile.

Seems to be a bug in conan with 2 profiles when the same dependency is in build requirement & requirements but with deleted options in one case.

@SSE4
Copy link
Contributor

SSE4 commented Feb 1, 2022

@SpaceIm I think you may have hit a hidden issue conan-io/conan#9839

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Feb 1, 2022

Ouch, maybe disable test package for macOS M1 for the moment?

openssl is also a requirement of cmake, so we hit a bug of conan v1 related to a conflict between deleted options of different versions of openssl in requirement & build requirement.
see conan-io/conan#9839
@SpaceIm SpaceIm force-pushed the openssl-1.x.x-modernize branch from 0fb1793 to 7fec453 Compare February 1, 2022 22:28
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 8 (7fec453c2c01d130fc8468aeb970d8e334508fc4):

  • openssl/1.1.1m@:
    All packages built successfully! (All logs)

  • openssl/1.1.1j@:
    All packages built successfully! (All logs)

  • openssl/1.1.1k@:
    All packages built successfully! (All logs)

  • openssl/1.1.1l@:
    All packages built successfully! (All logs)

  • openssl/1.1.1d@:
    All packages built successfully! (All logs)

  • openssl/1.1.1f@:
    All packages built successfully! (All logs)

  • openssl/1.1.0l@:
    All packages built successfully! (All logs)

  • openssl/1.1.1g@:
    All packages built successfully! (All logs)

  • openssl/1.1.1c@:
    All packages built successfully! (All logs)

  • openssl/1.1.1i@:
    All packages built successfully! (All logs)

  • openssl/1.1.1h@:
    All packages built successfully! (All logs)

  • openssl/1.1.0k@:
    All packages built successfully! (All logs)

  • openssl/1.1.1e@:
    All packages built successfully! (All logs)

  • openssl/1.0.2s@:
    All packages built successfully! (All logs)

  • openssl/1.0.2t@:
    All packages built successfully! (All logs)

  • openssl/1.0.2u@:
    All packages built successfully! (All logs)

@prince-chrismc
Copy link
Contributor

@ericLemanissier
Copy link
Contributor

indeed. and this should have been fixed by pylint-dev/pylint@107f59e. I'll do some investigations here.
In the meantime, we could use the usual property

@property
def _user_info_build(self):
# If using the experimental feature with different context for host and
# build, the 'user_info' attributes of the 'build_requires' packages
# will be located into the 'user_info_build' object. In other cases they
# will be located into the 'deps_user_info' object.
return getattr(self, "user_info_build", self.deps_user_info)

@conan-center-bot conan-center-bot merged commit 96249d3 into conan-io:master Feb 7, 2022
@SpaceIm SpaceIm deleted the openssl-1.x.x-modernize branch February 7, 2022 10:20
@SpaceIm SpaceIm mentioned this pull request Feb 14, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants