Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting msvc compiler in profiles for Visual Studio >= 17.10 #248

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Aug 8, 2024

Brings a logic similar to the one implemented in https://github.com/conan-io/conan/pull/15588/files that was merged after the breaking change in MSVC versioning: https://devblogs.microsoft.com/cppblog/msvc-toolset-minor-version-number-14-40-in-vs-2022-v17-10/

Closes: #247
Related to: conan-io/conan#16239

@czoido czoido added this to the 2.0.7 milestone Aug 8, 2024
@czoido czoido requested review from AbrilRBS and danimtb August 8, 2024 05:46
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch :)

@czoido czoido merged commit a8d26af into develop2 Aug 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conan doesn't use the latest MSVC toolset version while building the dependencies
3 participants