Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified app compatibility and defined default cppstd compatibility #11095

Merged
merged 8 commits into from
May 6, 2022
Merged

Simplified app compatibility and defined default cppstd compatibility #11095

merged 8 commits into from
May 6, 2022

Conversation

lasote
Copy link
Contributor

@lasote lasote commented Apr 25, 2022 •
edited by memsharded
Loading

Close #6157
Close #10921

@lasote lasote added this to the 2.0.0-alpha7 milestone Apr 25, 2022
lasote
lasote commented Apr 25, 2022
View reviewed changes
conans/model/settings.py Outdated Show resolved Hide resolved
@lasote lasote changed the title POC: Simplified app compatibility and defined default cppstd compatibility Simplified app compatibility and defined default cppstd compatibility Apr 26, 2022
@lasote lasote requested a review from memsharded April 26, 2022 09:01
@memsharded memsharded self-assigned this May 3, 2022
@lasote lasote marked this pull request as ready for review May 3, 2022 11:39
memsharded
memsharded approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is looking good, to talk a couple of minor issues about implementation and "uglyness"

conans/model/settings.py Outdated Show resolved Hide resolved
conans/client/graph/compatibility.py Outdated Show resolved Hide resolved
memsharded
memsharded approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@memsharded memsharded merged commit 90f080f into conan-io:develop2 May 6, 2022
This was referenced May 6, 2022
Closed
Closed
@Twon Twon mentioned this pull request Jan 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
2.0.0-alpha7
Development

Successfully merging this pull request may close these issues.
2 participants
@lasote @memsharded