-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set some CMakeDeps properties from consumer #12609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, clean and promising to deliver something useful.
A couple minor things to discuss, good job.
conans/test/integration/toolchains/cmake/cmakedeps/test_cmakedeps.py
Outdated
Show resolved
Hide resolved
Looks very promising for conan-center as well, to avoid breakage in recipes when their dependencies break these properties (for example when suddenly a new version of a library implements a CMake config file, we have to update these names in this recipe, but it can break downstream recipes which were relying on default values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great! 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing!!!
Changelog: Feature: Provide the ability to set CMakeDeps properties from consumer side.
Docs: conan-io/docs#2827
Gives you the possibility to overwrite some properties set in dependencies in CMakeDeps:
cmake_file_name
,cmake_target_name
,cmake_find_mode
,cmake_module_file_name
andcmake_module_target_name
The interface is:
for the cases with
build_context_activated
:You can also invalidate from consumer the properties set upstream assigning a
None
:Closes: #12534
Close #7118