-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an error that occurred when using conan.tools.scm.Git.fetch_commit()
in a subfolder
#17369
Fix an error that occurred when using conan.tools.scm.Git.fetch_commit()
in a subfolder
#17369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks very much @bkarasm
Please don't forget to sign the CLA above (or if you signed, sometimes when not using the same email as the Github one, Github doesn't recognize the signature), so we can merge it for next release. Thanks again for your contribution! |
Seems tests are broken in Linux only (work in Windows and Mac): TestGitShallowClone.test_clone_to_subfolder
|
@memsharded I'll take a look at the failing tests later today. Regarding the CLA I already signed it using the same account that I contributed with. Not sure why it still shows it is pending. |
A different test that verifies |
Thanks for following up! The CI is now green, ready to be merged. |
fdb4353
to
bcee7f7
Compare
Thanks @memsharded . Indeed that was the case. It should be fixed now. |
Merged, it will be in next Conan 2.10. Thanks very much for your contribution! |
Changelog: Fix: Fixed an error that occurred when using
conan.tools.scm.Git.fetch_commit()
in a subfolder.Docs: Omit
Fixes #17295