-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken cpp_info.location
deduction due to unsanitized regex
#17430
Conversation
722ea8a
to
d6e9c5d
Compare
The location detection could be improved further, still. It should fall back to the fuzzy regex only if an exact match is not found.
|
Unrelated, but too minor for a separate issue - using
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
We would like to start first with some unit test that would fail without this change. This is the best way to move forward without breaking the addressed issue because is not properly covered.
Agree, if you want you can just replace that with a |
Merged, thanks for the contribution, it will be in next Conan 2.11 |
Changelog: Fix: Fix broken
cpp_info.location
deduction due to unsanitized regex.Docs: Omit
Using
grpc
with-c tools.cmake.cmakedeps:new=will_break_next
currently fails with:This PR fixes the location detection failure due to the unsanitized
+
symbols in the library name.