Feature/lock upgrade #17577
Feature/lock upgrade #17577
Conversation
| c.run(f"export libb --version=1.1") | ||
| c.run(f"export libb --version=1.2") | ||
| c.run(f"export libc --version=1.1") | ||
| c.run("lock upgrade . --update-requires=liba/* --update-requires=libb/[*] --update-build-requires=libc/[*]") |
There was a problem hiding this comment.
It would be great to check that an --update-xxx doesn't update if the provided version or version range is not in the lockfile, and as such is not removed/unlocked.
There was a problem hiding this comment.
Yes! This is already being covered in this test case
https://github.com/conan-io/conan/pull/17577/files#diff-1f71b92a9bc5411618c92c12f2976cd7722225a096b9b85a1766d5fe9df533f3R429
There was a problem hiding this comment.
Not that case. The case when:
- The recipe
requires()contains a version range that would accept the new versions, likerequires("libb/[*]") - The
conan lock upgrade --update-requires=libb/[>2.0]will not upgrade the existinglibb/1.1, even if it is in the recipe valid range.
Co-authored-by: Abril Rincón Blanco <rubenrb@jfrog.com>
perseoGI
force-pushed
the
feature/lock_upgrade
branch
from
eb29a17 to
36b7aa0
Compare
| else: | ||
| return node.ref.matches(ref, is_consumer=None) | ||
| updatable_deps = defaultdict(list) | ||
| for node in expand_graph().nodes: |
There was a problem hiding this comment.
I think this might be a bit overkill, I'd try to leverage the existing conan lock remove functionality.
| subparser.add_argument('--update-python-requires', action="append", help='Update python-requires from lockfile') | ||
| subparser.add_argument('--update-config-requires', action="append", help='Update config-requires from lockfile') | ||
| subparser.add_argument('--build-require', action='store_true', default=False, help='Whether the provided reference is a build-require') | ||
| subparser.add_argument('--transitives', action='store_true', default=False, help='Upgrade also transitive dependencies') |
There was a problem hiding this comment.
I'd probably drop the --transitives argument at the moment and focus on just 1 use case to start with, start more minimalistic.
| from conan.internal.model.version import Version | ||
| from conan.internal.model.version_range import VersionRange |
There was a problem hiding this comment.
We have learned these are problematic, and we are moving away of the cli layer importing anything else besides cli and api layers. So the best would be to put the required functionality directly into the api layer
Changelog: Feature: New
lock upgradecommand to automatically upgrade desired dependencies resolving the graphDocs: TODO
developbranch, documenting this one.Fix #16636
The objective of this subcommand is to provide an easy and direct CLI interface to upgrade a (single / multiple) reference(s) in a lockfile: