Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpp_info components #5408
cpp_info components #5408
Changes from all commits
e743bd2
7073291
66289a7
07f90a7
25a2776
a100bc2
9643fea
e43b442
14dc504
b00a93c
06e2117
9b53334
61981a2
5509638
f6df365
e88b6f1
6c8bd40
831172c
058ed4e
6d4898a
0d9ba39
db8b873
b098c12
6ab1bdb
2f82336
d1d2ffc
be74c0d
1e6e1fd
6a2e2f7
b32e3b9
4bb2db2
4b49026
62a9782
b756503
aef1a51
b085211
ebd80e3
63f8235
2c3e3d7
c01ba50
d150060
f61e2d9
0dbb943
c3da770
195665c
ff6fca3
1c95d9b
6cdda0f
93f6c8d
5f5f172
1036bd8
9696a4a
b17f823
2273c62
6030868
a32a354
91ac38b
87aa4b9
c06bcb5
ad6ef1c
1fd57c2
3043d0d
3883c1d
c671b83
d2a169a
3c3a955
b4328a7
dcaf7c6
390fdc9
3f19440
654f096
06f60b2
6f0ef7e
3b35ffb
fe4bcaf
7442fb9
04f58c7
8835f62
86a8643
ac59597
cb85171
4ec7be0
90d23a0
c742157
a7a6dff
67c1dcd
3a3b7cd
00d929c
f59ed93
68c877f
1497ab8
9d79323
b4755b7
46eb33a
4609c2f
c8444e2
c8382ef
663fe0a
68466ec
3ff43ea
ce00092
e9311c6
868ff15
6ea072f
ab9a3e8
ccea5e9
293a566
98530c7
a778dad
42b69f9
4b388d1
f7e76e4
f3049e7
2c54491
80d30ab
ee2d0cf
4a64b7c
368518f
3be683b
1afc3d8
b13d7c9
8a4d827
417c9ab
20138fc
6b9028f
a0aca26
0ccae68
997bea3
588e283
a1e1754
38fcb23
b0377ac
1f2b7fe
5cea0ce
aeedb5b
f492491
114a41d
7540838
0c03036
29b2b81
89c378a
5a0ca0f
ae760f5
9068b8d
994b14f
b959969
53b2102
d90721e
f34fc6d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say this is also changing behavior, and it won't be recovering the data for the aggregated variables.
Why changing it? Seems risky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aggregated variables are recovered and composed of the values gathered from each dependency. So no need to read them or recover, as they will be composed when requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put a comment there: "None correspond to the aggregated values from all the dependencies, we can skip it because we are assigning the dependencies individually and can get the aggregated value"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why this is being changed, and why this processing is necessary now. Any idea @lasote?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say previously you were getting the aggregated info and now it is getting the components info to aggregate it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name has to be assigned here before so the user can later change this name and the value is preserved. Setting this name in deps_cpp_info.update() will overwrite the name value when the info is propagated