refactor GraphBinariesAnalyzer #5836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
* Added required = True to subparsers in order to print error message in Py2 and Py3. * sync * basic concurrent upload at reference level with futures * revert changes * add line * Lock buggy urllib3 (conan-io#5808) * app simplifying (conan-io#5806) * Apply lockfile before updating downstream requires (conan-io#5771) * apply graph_lock before looking for overrides * first step: get rid of the warning * cleaner if graph_lock is passed to the function * only update requires upstream if no lockfile is applied * fix tests * Deprecation of CONAN_USERNAME and CONAN_CHANNEL: fix error message (conan-io#5756) * if CONAN_USERNAME and CONAN_CHANNEL are deprecated, the error cannot recommend them * update tests accordingly * test client load() file method (conan-io#5815) * no user/channel repr without _ (conan-io#5817) * no user/channel repr without _ * minor fixes * fix tests * Remove py34 (conan-io#5820) * fix upload package id (conan-io#5824) * - update macOS, watchOS, tvOS, iOS version numbers (conan-io#5823) * Refresh token client support. (conan-io#5662) * Refresh token client support. Missing tests. Missing migration * public method * WIP * Refresh almost there * Removed prints * Try migrate * Migration * Add comment * Refresh token flow following RFC recommentations * Refresh ok * review * Remove traces * Refactor capabilities * Removed tmp file * Review * conan-io#5819 Show warning message for Python 3.4 (conan-io#5829) * conan-io#5819 Show warning message for Python 3.4 - Add new warning message for python 3.4 which is no longer supported - Added funcional tests to validate both python 3.4 and 2.x Signed-off-by: Uilian Ries <uilianries@gmail.com> * conan-io#5819 Fix broken tests Signed-off-by: Uilian Ries <uilianries@gmail.com> * Add cpp_info.name to cmake and pkg_config generators (conan-io#5598) * Add cpp_info.name to cmake generators * Fix unit tests to mimic real behavior * cmake_paths test * add test for cmake generator * Add cmake_find_package test * fix test in py3 * Applied cpp_info.name to pkg_config generator * check different name in pkg_config * use pyreq short path if exists * sync with develop * revert change * pass correct conanfile * add test * remove line * clean test
* Add a test * Raise an error if no remote found * Check that we don't raise an error if the state is already in the required state * Raise an error only if the remote name is not a wildcard * Check that we don't raise an error with a wildcard if there are no remotes
…5854) * Removed go test files and references to golang from README * Removed golang from README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Omit
Docs: Omit
This is a pure refactor, breaking a very large function into smaller pieces. It might be also slightly faster:
Also:
evaluatedcaching helper as an argument, but hide it in GraphBinaryAnalyzer, the only one using this cache.#tags: slow