Use cpp_info.name lower case in pkg-config generator when defined #5988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Oct 29, 2019
SSE4
reviewed
Oct 29, 2019
| for _, cpp_info in self.deps_build_info.dependencies: | ||
| ret["%s.pc" % cpp_info.name] = self.single_pc_file_contents(cpp_info) | ||
| for depname, cpp_info in self.deps_build_info.dependencies: | ||
| name = cpp_info.name.lower() if cpp_info.name != depname else depname |
There was a problem hiding this comment.
so, if cpp_info.name == depname it won't go lowercase?
There was a problem hiding this comment.
that's what the logic says 😄
There was a problem hiding this comment.
yeah, but is it expected? AFAIK pkg-config file should be always in lower-case, right?
There was a problem hiding this comment.
I have seen that it is a very extended practice, but AFAIK pkg-config does not force the name to be lower-case
There was a problem hiding this comment.
checked:
http://manpages.ubuntu.com/manpages/cosmic/man5/pc.5.html
https://dev.gentoo.org/~mgorny/pkg-config-spec.html
there is no hard requirement for lower-case name
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Use cpp_info.name lower case in pkg-config generator when defined
Docs: omit
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.