Fix typos, grammar and spelling in README.rst #6015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
memsharded
approved these changes
Nov 1, 2019
| @@ -112,7 +112,7 @@ You can run **conan** client and server in Windows, MacOS, and Linux. | |||
| search Searches package recipes and binaries in the local cache or in a remote. | |||
| Creator commands | |||
| new Creates a new package recipe template with a 'conanfile.py'. | |||
| create Builds a binary package for recipe (conanfile.py) located in current dir. | |||
| create Builds a binary package for a recipe (conanfile.py) located in the current dir. | |||
There was a problem hiding this comment.
These might be automatically obtained from the conan --help command, maybe it would make sense to fix them in the app code.
| @@ -214,7 +214,7 @@ These should work for OS X: | |||
| $ export CONAN_COMPILER=clang | |||
| $ export CONAN_COMPILER_VERSION=3.5 | |||
| Finally, there are some tests that use conan to package Go-lang | |||
| Finally, some tests use conan to package Go-lang | |||
There was a problem hiding this comment.
We have recently removed the go-lang tests, this section about go-lang might be removed.
|
This is good, many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.