Fix several issues with download command and revisions #6138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czoido
changed the title
memsharded
requested changes
Nov 27, 2019
memsharded
approved these changes
Nov 29, 2019
memsharded
pushed a commit
to memsharded/conan
that referenced
this pull request
Dec 3, 2019
* fail if specifying rev with revs disabled * fix reference with revisions * add package revision to id * add tests * check revisions * fix create without user channel * add test without user channel * minor changes * skip depending on revisions * add test with fake revision * remove server from test * test for older revision in server * divide test
lasote
pushed a commit
that referenced
this pull request
Dec 3, 2019
* compatible_package build=missing * move CONAN_EXPORTED and CONAN_IN_LOCAL_CACHE outside cmake_flags * do not extract build_type and in_local_cache * it is moved to the end of the command line * Change help message for --build policy for create command (#6131) * change build policy for create * change to package name * remove unused imports * client.load() (#6140) * Fixes #6044 Improve error with malformed settings yml (#6059) * Fixes #6044 Improve error raised when 'settings.yml' cannot be parsed * add tests for invalid settings YAML file * Fix several issues with download command and revisions (#6138) * fail if specifying rev with revs disabled * fix reference with revisions * add package revision to id * add tests * check revisions * fix create without user channel * add test without user channel * minor changes * skip depending on revisions * add test with fake revision * remove server from test * test for older revision in server * divide test * Fix upload behaviour when using revisions for packages (#6143) * wip * fail if trying to upload different revision than in cache * fail if rev specified without revs enabled * add tests * change line format * fix python 27 * minor changes * Fix SyntaxWarning in Python 3.8 (#6165) * - generate ConfigVersion.cmake file (#6063) Signed-off-by: SSE4 <tomskside@gmail.com> * Fixes #5925 Make the first line from find program as the result (#6039) * 3. extra separator in Windows * Improve the error message when failed to connect to remote * Improve the error message when failed to connect to remote * Improve the error message when failed to connect to remote * Revert unwanted changes * Pick the first match which is the best match * Pick the first match which is the best match * make reversed explicit (better that [::-1]) * Fix output folder for conanworkspace.cmake when rebuilding dependencies (#6060) * Added required = True to subparsers in order to print error message in Py2 and Py3. * sync * basic concurrent upload at reference level with futures * revert changes * add line * Lock buggy urllib3 (#5808) * app simplifying (#5806) * Apply lockfile before updating downstream requires (#5771) * apply graph_lock before looking for overrides * first step: get rid of the warning * cleaner if graph_lock is passed to the function * only update requires upstream if no lockfile is applied * fix tests * Deprecation of CONAN_USERNAME and CONAN_CHANNEL: fix error message (#5756) * if CONAN_USERNAME and CONAN_CHANNEL are deprecated, the error cannot recommend them * update tests accordingly * test client load() file method (#5815) * no user/channel repr without _ (#5817) * no user/channel repr without _ * minor fixes * fix tests * Remove py34 (#5820) * fix upload package id (#5824) * - update macOS, watchOS, tvOS, iOS version numbers (#5823) * Refresh token client support. (#5662) * Refresh token client support. Missing tests. Missing migration * public method * WIP * Refresh almost there * Removed prints * Try migrate * Migration * Add comment * Refresh token flow following RFC recommentations * Refresh ok * review * Remove traces * Refactor capabilities * Removed tmp file * Review * #5819 Show warning message for Python 3.4 (#5829) * #5819 Show warning message for Python 3.4 - Add new warning message for python 3.4 which is no longer supported - Added funcional tests to validate both python 3.4 and 2.x Signed-off-by: Uilian Ries <uilianries@gmail.com> * #5819 Fix broken tests Signed-off-by: Uilian Ries <uilianries@gmail.com> * Add cpp_info.name to cmake and pkg_config generators (#5598) * Add cpp_info.name to cmake generators * Fix unit tests to mimic real behavior * cmake_paths test * add test for cmake generator * Add cmake_find_package test * fix test in py3 * Applied cpp_info.name to pkg_config generator * check different name in pkg_config * sync with develop * save conanworkspace.cmake relative to base folder * add test * siplify test * add context manager to build folder * change indent * Publish 'artifacts.properties' using matrix params (#6014) * draft to test * add missing argument to functions * rename 'put_headers' to 'artifact_properties' * store matrix params as the preformatted string in the router * fallback to empty string * something going wrong: too many cchanges * at least these are not needed * typo * it was only needed to remove the matrix_params for the bottle server * soooo * remove class name * fix minor bug * now with revisions too * make docs with triple double quotes * we need to modify the conan_server to accept matrix_params too * fix tests * add tests with artifacts.properties * quote values of matrix params * we can stack routes * add tests with many different values * remove changes not needed * use server capability to choose the URL to build * do not send headers if matrix_params capability * do not add 'matrix_params' functionality to conan-server * rename variable, 'file' is reserved * remove change uneeded * conan server does not support matrix params at all * use the proper if/else * Add res dir to the variables when using cmake_find_package. (issue 3722) (#6166) * skip downloading call to to_file_bytes (#6142) * remove syntax warning (#6174) * fix cwd issues in set_version() evaluation (#6130) * fix cwd issues in set_version() evaluation * explicit self.recipe_folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Fix different problems when using
conan downloadwith revisions.Docs: Omit
This PR fixes the following problems when using revisions with
conan downloadcommand:It also fixes that when using
createin theTurboTestClientwithout user and channel the command failed.Closes #6106
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.