Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new concept list by Berry and Berry 1987 #1400

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Adding new concept list by Berry and Berry 1987 #1400

merged 3 commits into from
Sep 25, 2024

Conversation

LinguList
Copy link
Contributor

Pull request checklist

  • add new concept list
  • add new metadata
  • add new Concepticon concept sets
    • checked whether the new concept(s) can be applied to existing lists with
      concepticon notlinked --gloss "NEW_GLOSS"
  • add new Concepticon concept relations
  • refine existing Concepticon concept set mappings
  • refine Concepticon glosses
  • refine Concepticon concept relations
  • refine Concepticon concept definitions
  • retire data

Additional information

...

@LinguList
Copy link
Contributor Author

@alzkuc, would you have time to review this PR?

@LinguList LinguList requested a review from alzkuc September 24, 2024 18:57
@LinguList
Copy link
Contributor Author

@MuffinLinwist, could you maybe also have a quick look? I'd like to merge the PR soon.

@LinguList
Copy link
Contributor Author

@MuffinLinwist and @alzkuc, sorry I did not follow our rules. I should've asked @alzkuc to be the one to moderate this PR, by assigning a reviewer.

Berry-1987-195-191 191 inside inside di dalam LOCATIVES 79 61 1606 INSIDE
Berry-1987-195-192 192 left side left side kiri LOCATIVES 80 62 244 LEFT
Berry-1987-195-193 193 near near dekat LOCATIVES 80 62 1942 NEAR
Berry-1987-195-194 194 outside outside di luar LOCATIVES 80 62 762 OUTSIDE
Copy link
Collaborator

@alzkuc alzkuc Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :-)

@alzkuc
Copy link
Collaborator

alzkuc commented Sep 25, 2024

hi @MuffinLinwist, would you please be so kind and take a quick look at this list? thank you!

Copy link
Collaborator

@MuffinLinwist MuffinLinwist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks perfect. I just added a small comments/question regarding one single mapping :) Other than that, we can merge.

Berry-1987-195-30 30 fish fish ikan NOUNS / Animate Nouns 65 47 227 FISH
Berry-1987-195-31 31 fly fly lalat NOUNS / Animate Nouns 65 47 1504 FLY (INSECT)
Berry-1987-195-32 32 husband husband suami NOUNS / Animate Nouns 65 47 1200 HUSBAND
Berry-1987-195-33 33 leech leech lintah NOUNS / Animate Nouns 65 47 949 WATER LEECH
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is specific for these languages, but could this not be just 2273 LEECH?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, @MuffinLinwist!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @LinguList again! whenever you have time, please let me know your thoughts on item 33 (leech - lintah), then we can merge :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I remembered that I myself added LEECH, since WATER LEECH was something like a synonym of LEECH for some time. Then I decided for WATER LEECH, as I thought LEECH was retired. But I better correct it :-)

@LinguList
Copy link
Contributor Author

I am waiting for the automated tests to pass. Thanks to @MuffinLinwist and @alzkuc !

@LinguList LinguList merged commit e4f0797 into master Sep 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants