Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new concept sets and applying them to existing datasets #1431

Merged
merged 28 commits into from
Nov 26, 2024

Conversation

alzkuc
Copy link
Collaborator

@alzkuc alzkuc commented Nov 25, 2024

This PR introduces several new concept sets and applies them to existing datasets (batch 2). If possible, please hold off on merging other PRs—especially ones with new concept sets—until this one is merged. Thanks!

  • add new concept list
  • add new metadata
  • add new Concepticon concept sets
    • checked whether the new concept(s) can be applied to existing lists with
      concepticon notlinked --gloss "NEW_GLOSS"
  • add new Concepticon concept relations
  • refine existing Concepticon concept set mappings
  • refine Concepticon glosses
  • refine Concepticon concept relations
  • refine Concepticon concept definitions
  • retire data

Additional information

...

@alzkuc
Copy link
Collaborator Author

alzkuc commented Nov 25, 2024

@LinguList would you please moderate (or even review) this for me? thank you!

@alzkuc alzkuc requested a review from LinguList November 25, 2024 11:20
adding one more concept set
@LinguList
Copy link
Contributor

I suggest I review this later this evening or this week.

@alzkuc
Copy link
Collaborator Author

alzkuc commented Nov 25, 2024

I suggest I review this later this evening or this week.

Perfect, thank you! :-)

Copy link
Contributor

@LinguList LinguList left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me, only this little thing with https not http.

vanDort-2007-50 van Dort, Sandra and Vong, Etain and Razak, Rogayah A. and Kamal, Rahayu Mustaffa and Meng, Hooi Poh 2007 50 naming test, basic English Malay http://journalarticle.ukm.my/1033/1/jurnal64.pdf vanDort2007 This is a Malay version of the Boston Naming Test (M-BNT) and its normative data. The M-BNT follows closely the general administration procedures of the original Boston Naming Test (BNT) but is different in terms of item content. A total of 29 items from the original 60 items on the test were deemed culturally and linguistically valid for the Malay population and were thus retained.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://journalarticle.ukm.my/1033/1/jurnal64.pdf -> https://journalarticle.ukm.my/1033/1/jurnal64.pdf (https not http)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for spotting that! changed it to https :-)

@alzkuc alzkuc merged commit a3e7b92 into concepticon:master Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants