Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gruehn-2008-200: Adjustments to Variable Names #1438

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

MiraAhmedovic
Copy link
Collaborator

@MiraAhmedovic MiraAhmedovic commented Jan 8, 2025

Pull request checklist

  • add new concept list
  • add new metadata
  • add new Concepticon concept sets
    • checked whether the new concept(s) can be applied to existing lists with
      concepticon notlinked --gloss "NEW_GLOSS"
  • add new Concepticon concept relations
  • refine existing Concepticon concept set mappings
  • refine Concepticon glosses
  • refine Concepticon concept relations
  • refine Concepticon concept definitions
  • retire data

Additional information

Some adjustments were made to the variable names in this dataset to more accurately match other existing variables.
...

@MiraAhmedovic
Copy link
Collaborator Author

I've made some adjustments, @AnnikaTjuka, would you care to take a look?

@MiraAhmedovic MiraAhmedovic changed the title Adjustments to Variable Names Gruehn-2008-200: Adjustments to Variable Names Jan 8, 2025
@AnnikaTjuka
Copy link
Collaborator

Many thanks for the updates. These are just consistency improvements to the header names, so I'll review them quickly.

Copy link
Collaborator

@AnnikaTjuka AnnikaTjuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MiraAhmedovic MiraAhmedovic merged commit e0b3122 into master Jan 8, 2025
1 check passed
@MiraAhmedovic MiraAhmedovic deleted the Changes_Gruehn_2008_200 branch January 8, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants