Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/refactor parent pool to 3 contracts #19

Merged
merged 22 commits into from
Sep 20, 2024

Conversation

lufaque
Copy link
Member

@lufaque lufaque commented Sep 17, 2024

Description

Concise description of proposed changes, We recommend using screenshots and videos for better description

Additional Information

Related Issues

Closes #{issue number}

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address:

Copy link

openzeppelin-code bot commented Sep 17, 2024

Feat/refactor parent pool to 3 contracts

Generated at commit: 1fce499988a4b86c2b000e5581a94ccbb6323837

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
1
0
8
38
49
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

// SPDX-License-Identifier: UNLICENSED
pragma solidity 0.8.20;

interface IParentPoolViewViaDelegate {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to generic wrapper

packages/hardhat/contracts/ParentPool.sol Outdated Show resolved Hide resolved
packages/hardhat/contracts/ParentPool.sol Outdated Show resolved Hide resolved
@lufaque lufaque merged commit 1fce499 into master Sep 20, 2024
1 check failed
@olegkron olegkron deleted the feat/refactor-parent-pool-to-3-contracts branch November 9, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants