Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IME input (e.g. Chinese, Japanese); fix auto-scroll to selection #361

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Fix IME input (e.g. Chinese, Japanese); fix auto-scroll to selection #361

merged 2 commits into from
Jul 20, 2020

Conversation

kswenson
Copy link
Member

@kswenson kswenson commented Jul 17, 2020 •
edited
Loading

Update to @concord-consortium/slate-editor 0.4.3

  • fixes IME (e.g. Chinese/Japanese/etc. keyboard) bugs
  • fixes auto-scroll to selection on toolbar actions

Update to lodash@4.17.19

  • eliminates security vulnerability warnings

@kswenson kswenson requested a review from jsandoe July 17, 2020 00:00
@kswenson
Update to @concord-consortium/slate-editor@0.4.2
93ab4d0 
- fixes IME (e.g. Chinese/Japanese/etc. keyboard) bugs
Update to lodash@4.17.19
- eliminates security vulnerability warnings
@kswenson kswenson changed the title Update to @concord-consortium/slate-editor@0.4.1 Fix IME input (e.g. Chinese, Japanese); fix auto-scroll to selection Jul 18, 2020
jsandoe
jsandoe approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@jsandoe jsandoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably the actual work for this PR is in the Slate Editor NPM project. 👍

@kswenson
Copy link
Member Author

kswenson commented Jul 20, 2020 •
edited
Loading

Presumably the actual work for this PR is in the Slate Editor NPM project.

Yes, sorry, I should have linked it:
concord-consortium/slate#1
concord-consortium/slate#2
concord-consortium/slate-editor#36

@jsandoe jsandoe merged commit 6897699 into master Jul 20, 2020
@jsandoe jsandoe deleted the ime-fixes branch July 20, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsandoe jsandoe jsandoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kswenson @jsandoe