fix: Passwords validations in signup form [PT-187798321] [PT-187798313] #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the update to React 18 the Formsy input validations broke as they relied on state updates being done before the validations. This commit changes the password confirmation validation to use a function that compares the passed form values. It also updates the the password length validations to remove the max length validation.
dougmartin
force-pushed
the
187798321-fix-passwords-do-not-match
branch
from
fd1a439
to
a3704cb
Compare
pjanik
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
So, the ,maxLength:10 might be my fault. I think I added that when I was fixing the Formsy-based code and wanted to test how the (multiple) validations work. I probably forgot to remove it afterward.
With the update to React 18 the Formsy input validations broke as they relied on state updates being done before the validations.
Hm, currently, everything works if the password contains both letters and numbers, but it fails when the password contains only numbers. How is this related to the React state?
If your custom validator fixes this issue (in theory both approaches should work the same), then that's great. However, I just want to ensure that we are indeed addressing the reported problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the update to React 18 the Formsy input validations broke as they relied on state updates being done before the validations.
This commit changes the password confirmation validation to use a function that compares the passed form values. It also updates the the password length validations to remove the max length validation.