Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old Permission Forms code and remove V2 suffix from the new one #1347

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

pjanik
Copy link
Member

@pjanik pjanik commented Jul 3, 2024

https://www.pivotaltracker.com/story/show/187613639

This PR removes all unnecessary old Permission Forms code and renames our new code to remove the V2 suffix, hopefully preventing confusion, especially since the API lives in the V1 directory. :)

@pjanik pjanik requested a review from bacalj July 3, 2024 19:53
Copy link
Contributor

@bacalj bacalj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great, and I sanity tested it.

@pjanik pjanik merged commit 2e46982 into master Jul 4, 2024
9 of 10 checks passed
@pjanik pjanik deleted the 187613639-rm-old-permission-forms-code branch July 4, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants