Update to go 1.15 and go mod #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kirillbilchenko <kirya7@gmail.com>
aoldershaw
requested changes
Oct 22, 2020
dockerfiles/alpine/Dockerfile
Outdated
| @@ -1,8 +1,8 @@ | |||
| FROM golang:alpine as builder | |||
| COPY . /go/src/github.com/concourse/github-release-resource | |||
| FROM golang:1.15-alpine AS builder | |||
There was a problem hiding this comment.
I don't think we want to actually pin this to 1.15 - just using golang:alpine will keep us at the latest go version.
There was a problem hiding this comment.
Let me change this, sounds reasonable
Signed-off-by: kirillbilchenko <kirya7@gmail.com>
aoldershaw
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to go 1.15 and go mod
Signed-off-by: kirillbilchenko kirya7@gmail.com