Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow release notes for a GitHub release to be autogenerated #119

Merged
merged 5 commits into from
Aug 25, 2022
Merged

Allow release notes for a GitHub release to be autogenerated #119

merged 5 commits into from
Aug 25, 2022

Conversation

coro
Copy link
Contributor

@coro coro commented Aug 24, 2022

Add a parameter to the OutParams to enable GitHub to autogenerated release notes for newly-created releases.

Additional info

Note that this parameter has no effect on updated releases, only newly-created releases. This is a limitation of the GitHub API - see google/go-github#2444 for more context.

This PR bumps the consumed version of github.com/google/go-github/v39 to v39.2.0.

Linked Issues

This closes #117 .

coro added 4 commits August 24, 2022 16:18
The test advice presented in the README did not work, due to the missing `base_image` ARG.

Signed-off-by: Connor Rogers <23215294+coro@users.noreply.github.com>
This parameter causes release notes to be autogenerated by GitHub when creating a new release.

Note this has no effect on updating existing releases due to google/go-github#2444

Signed-off-by: Connor Rogers <23215294+coro@users.noreply.github.com>
Signed-off-by: Connor Rogers <23215294+coro@users.noreply.github.com>
Signed-off-by: Connor Rogers <23215294+coro@users.noreply.github.com>
@coro coro requested review from xtremerui and removed request for aoldershaw August 24, 2022 15:20
Signed-off-by: Connor Rogers <23215294+coro@users.noreply.github.com>
@coro coro requested a review from xtremerui August 25, 2022 10:19
Copy link
Contributor

@xtremerui xtremerui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xtremerui xtremerui merged commit 0fadec1 into concourse:master Aug 25, 2022
ramonskie added a commit to cloudfoundry/bosh-bootloader that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add "Generate release notes" option when creating a release
2 participants