-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow role assumption #153
Conversation
I needed to use the AWS role assumption mechanism after logging in with the given credentials so I have implemented it. |
…en credentials Signed-off-by: Marc Schiereck <mdreem@fastmail.fm>
Signed-off-by: Marc Schiereck <mdreem@fastmail.fm>
Signed-off-by: Marc Schiereck <mdreem@fastmail.fm>
Signed-off-by: Marc Schiereck <mdreem@fastmail.fm>
ee91723
to
746c018
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review! It looks great, I was wondering if there would be a way to have it use the role ARN in a few specific integrations tests and without it in others? Just so that we can have the integration tests run tests on both using role ARN and without?
Thanks for checking it out! Then I was curious if it still works in all use-cases, so I just switched the bucket, when I ran the test-suite. But if you think there are some specific tests that are sufficient, I think it would also be possible. I'd just need to define an additional parameter for the bucket using the role-assumption, I guess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everything here is great already, I'm just going to merge it because its been delayed for so long haha. I was just suggesting the test changes so that we can run the tests once to cover all the cases of using role ARN and without but it's honestly not a big deal! Thanks for the PR!!
Enable AWS role assumption mechanism after logging in with the given credentials. See #151.