Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abseil v20230125 LTS #53

Merged
merged 10 commits into from
Feb 10, 2023
Merged

abseil v20230125 LTS #53

merged 10 commits into from
Feb 10, 2023

Conversation

h-vetinari
Copy link
Member

Seems the bot didn't pick this one up.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@njzjz
Copy link
Member

njzjz commented Feb 7, 2023

#error "C++ versions less than C++14 are not supported."

@h-vetinari
Copy link
Member Author

#error "C++ versions less than C++14 are not supported."

Yeah, I know, I just forgot to drop them. However, there's some more libs that haven't been properly taken care of on the windows DLL side which I'm just looking into.

@h-vetinari
Copy link
Member Author

@conda-forge/abseil-cpp
This should be good to go. A bunch of patches were upstreamed successfully (with the exception of abseil/abseil-cpp#1115 that's yet to be merged), otherwise this is a pretty standard version bump.

Of course, dropping C++11 raises the question if we should even keep building C++14 and the respective static libs. To the best of my knowledge, all feedstocks in cond-aforge depending on abseil are now on C++17, so arguably this isn't necessary anymore. On the other hand, we haven't fixed the situation with #45 yet, which will only get dicier now that protobuf has started depending on abseil.

So far there shouldn't be many (relevant) ABI differences between C++17 and C++20, but those will very likely arise over time.

CC @conda-forge/core @conda-forge/libprotobuf @coryan @pitrou @rgommers

@h-vetinari
Copy link
Member Author

Ah yes, and I wanted to remove the compatibility output for the old name abseil-cpp. Based on this search it's not depended upon by a feedstock in conda-forge anymore.

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of the abseil-cpp output seems fine.

@h-vetinari
Copy link
Member Author

On further reflection, I decided to remove the libabseil-static outputs. They did not fulfill their intended role as encapsulating the ABI concerns, and are not in use anywhere AFAIK. They can of course be readded if ever the need arises.

Barring further comments, I'll merge this in 24h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants