-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abseil v20230125 LTS #53
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2023.02.06.13.55.07
|
Yeah, I know, I just forgot to drop them. However, there's some more libs that haven't been properly taken care of on the windows DLL side which I'm just looking into. |
@conda-forge/abseil-cpp Of course, dropping C++11 raises the question if we should even keep building C++14 and the respective static libs. To the best of my knowledge, all feedstocks in cond-aforge depending on abseil are now on C++17, so arguably this isn't necessary anymore. On the other hand, we haven't fixed the situation with #45 yet, which will only get dicier now that protobuf has started depending on abseil. So far there shouldn't be many (relevant) ABI differences between C++17 and C++20, but those will very likely arise over time. CC @conda-forge/core @conda-forge/libprotobuf @coryan @pitrou @rgommers |
…nda-forge-pinning 2023.02.06.13.55.07
Ah yes, and I wanted to remove the compatibility output for the old name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removal of the abseil-cpp
output seems fine.
…nda-forge-pinning 2023.02.08.20.12.13
On further reflection, I decided to remove the Barring further comments, I'll merge this in 24h. |
Seems the bot didn't pick this one up.