Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wetterdienst request #1221

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Dec 12, 2024

Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

What will happen when a package is marked broken?

  • Our bots will add the broken label to the package. The main label will remain on the package and this is normal.
  • Our bots will rebuild our repodata patches to remove this package from the repodata.
  • In a few hours after the anaconda.org CDN picks up the new patches, you will no longer be able to install the package from the main channel.

Ping @conda-forge/wetterdienst

Checklist:

  • I want to mark a package as broken (or not broken):

    • Added a description of the problem with the package in the PR description.
    • Pinged the team for the package for their input.
  • I want to archive a feedstock:

    • Pinged the team for that feedstock for their input.
    • Make sure you have opened an issue on the feedstock explaining why it was archived.
    • Linked that issue in this PR description.
    • Added links to any other relevant issues/PRs in the PR description.
  • I want to request (or revoke) access to an opt-in CI resource:

    • Pinged the relevant feedstock team(s)
    • Added a small description explaining why access is needed
  • I want to copy an artifact following CFEP-3:

    • Pinged the relevant feedstock team(s)
    • Added a reference to the original PR
    • Posted a link to the conda artifacts
    • Posted a link to the build logs
  • I want to add a package output to a feedstock:

    • Pinged the relevant feedstock team(s)
    • Added a small description of why the output is being added.

@xylar xylar requested a review from a team as a code owner December 12, 2024 12:51
@xylar
Copy link
Contributor Author

xylar commented Dec 12, 2024

@ocefpaf, there was a typo in #1217. I incorrectly copied from another request. Would you take a look at this and merge if you agree with my fix?

Sorry about that!

@ocefpaf ocefpaf merged commit a22bf3d into conda-forge:main Dec 12, 2024
1 check passed
@ocefpaf
Copy link
Member

ocefpaf commented Dec 12, 2024

@ocefpaf, there was a typo in #1217. I incorrectly copied from another request. Would you take a look at this and merge if you agree with my fix?

Humm, your reviewer should have caught that one. Really bad reviewer!

@xylar
Copy link
Contributor Author

xylar commented Dec 12, 2024

Thanks again!

@xylar xylar deleted the add-wetterdienst-extras branch December 12, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants