Rework libarrow activate.sh with finer-grained checks and logging, with final changes #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the approach suggested by @alippai in <conda-forge#1065 (comment)>
The effective part of conda-forge#1033 seems to be checking writability of `WRAPPER_DIR` as opposed to `GDB_PREFIX`. Replacing `ln -sf` with `rm -f; ln -s` seems to have led to conda-forge#1060.
Set `LIBARROW_ACTIVATE_LOGGING=1` to enable log messages.
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
This reverts commit a63dbba.
maresb
requested review from
cpcloud,
h-vetinari,
jakirkham,
jreback,
kou,
kszucs,
leifwalsh,
nealrichardson,
pcmoritz,
pearu,
pitrou,
robertnishihara,
siddharthteotia,
wesm and
xhochy
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Oh, it passed. Will close and fast-forward the other branch... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1065 with the todos taken care of.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)