Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrow 13.0.0 #1124

Merged
merged 6 commits into from
Aug 24, 2023
Merged

arrow 13.0.0 #1124

merged 6 commits into from
Aug 24, 2023

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Jul 24, 2023 •
edited
Loading

Let's see what building off of the latest tag brings. This helps prepare for when the bot comes around, but also to button up apache/arrow#35637

For arrow 13 I'm also planning to remove the old naming of the outputs arrow-cpp & arrow-cpp-proc.

Closes #1139

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

This was referenced Jul 27, 2023
Closed
Merged
@h-vetinari h-vetinari mentioned this pull request Jul 28, 2023
Closed
5 tasks
@h-vetinari h-vetinari mentioned this pull request Aug 16, 2023
Open
@h-vetinari h-vetinari changed the title arrow 13 arrow 13.0.0 Aug 23, 2023
@conda-forge conda-forge deleted a comment from conda-forge-webservices bot Aug 23, 2023
@conda-forge conda-forge deleted a comment from conda-forge-webservices bot Aug 23, 2023
@h-vetinari h-vetinari marked this pull request as ready for review August 23, 2023 18:08
@h-vetinari
Copy link
Member Author

@conda-forge/arrow-cpp, are people OK with dropping the old arrow-cpp compatibility outputs?

We've now reached the point where the last 4 releases (10-13) all have libarrow, so I think we could/should drop it. I can add a rule to the linter to warn any remaining users of arrow-cpp to move to `libarrow.

@xhochy
Copy link
Member

xhochy commented Aug 24, 2023

Result of an offline discussion on arrow-cpp between @h-vetinari is that we will keep the output for version 13 and will drop them with 14. Currently, a package that builds against Arrow C++ must use arrow-cpp as we don't have the output yet for version 9.

@h-vetinari
arrow 13.0.0
303cb7d
@h-vetinari
update expected header for acero
990f0fc
@h-vetinari
remove obsolete test skips
896785e
@h-vetinari
backport patch to fix a failing test
e8f9e77
@h-vetinari
add 12.x to abi_migration_branches
c4eee7b 
I had considered switching patterns for 10.x and 11.x already;
it was a mistake not to do it, so do it now. Better do the right
thing long-term; it'll only take a little while until the old
pattern falls off the radar.
@h-vetinari
MNT: Re-rendered with conda-build 3.26.1, conda-smithy 3.24.1, and co…
8fede80 
…nda-forge-pinning 2023.08.23.22.00.02
@h-vetinari
Copy link
Member Author

Currently, a package that builds against Arrow C++ [for all currently supported versions] must use arrow-cpp as we don't have the output yet for version 9.

... which is solved once we drop off arrow v9 after the v13 migration. 🙃

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Aug 24, 2023
@h-vetinari
Copy link
Member Author

Actually, since this passed already before, in it goes... :)

@h-vetinari h-vetinari merged commit fd4e1f1 into conda-forge:main Aug 24, 2023
@h-vetinari h-vetinari deleted the 13 branch August 24, 2023 08:24
@h-vetinari h-vetinari mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud Awaiting requested review from cpcloud cpcloud is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@jreback jreback Awaiting requested review from jreback jreback is a code owner

@kou kou Awaiting requested review from kou kou is a code owner

@kszucs kszucs Awaiting requested review from kszucs kszucs is a code owner

@leifwalsh leifwalsh Awaiting requested review from leifwalsh leifwalsh is a code owner

@nealrichardson nealrichardson Awaiting requested review from nealrichardson nealrichardson is a code owner

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

@pearu pearu Awaiting requested review from pearu pearu is a code owner

@pitrou pitrou Awaiting requested review from pitrou pitrou is a code owner

@robertnishihara robertnishihara Awaiting requested review from robertnishihara robertnishihara is a code owner

@siddharthteotia siddharthteotia Awaiting requested review from siddharthteotia siddharthteotia is a code owner

@wesm wesm Awaiting requested review from wesm wesm is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-vetinari @xhochy