-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LAPACK 3.11.0 #114
base: main
Are you sure you want to change the base?
LAPACK 3.11.0 #114
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in conda-forge/lapack-feedstock#67, this PR should be merged first to avoid a window where but no blas implementation except netlib is on 3.11 (which would cause it to be installed everywhere during that time).
recipe/meta.yaml
Outdated
{% set version_major = version.split(".")[0] %} | ||
# blas_major denotes major infrastructural change to how blas is managed | ||
{% set blas_major = "2" %} | ||
# make sure we do not create colliding version strings of output "blas" | ||
# for builds across lapack-versions within the same blas_major | ||
{% set blas_minor = build_num + 100 %} | ||
{% set blas_minor = build_num + 300 %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaving this as is so we keep the + 200
for LAPACK 3.10, if we ever need to build that for whatever reason.
Not sure what's happening with openblas on osx.
The |
I cannot seem to get rid of the channel confusion for blis on windows either, it pulls in a too old lapack:
Pinning the version just leads to
|
c0af6fa
to
011a282
Compare
@martin-frbg, sorry for another ping, I'm completely stumped whats happening with openblas on osx-64 (against the LAPACK 3.11 test suite). Those failures were already there with 0.3.27, and have remained with 0.3.28. I cannot make heads or tails of what's happening;
I have no idea why the symbol name (according to the logs) seems corrupted? Presumably this is also the reason why the linker fails to find it... However, this only happens in this combination of libraries/platforms, so this is very strange. The overall results are:
which is quite a bit worse (both overall and in detail, e.g. "other error") than a comparable result with another backend on osx blis on osx-64
or (note also the wildly different number of tests 🤔) openblas on linux-64
There are hundreds of lines of logs along the lines of
I checked the commit history of the
Not all symbols have the mojibake, but quite a number of them do (which was what I was trying to dig into, but I cannot tell where the symbol names get constructed, much less how they'd get messed up).
Any ideas would be appreciated! 🙏 |
This feedstock is only building the test suite from reference LAPACK. It was my impression that If I need to patch openblas instead (or additionally), I can do that... |
…nda-forge-pinning 2024.11.04.11.32.56
…nda-forge-pinning 2024.11.07.16.38.57
…nda-forge-pinning 2024.11.08.21.03.17
…nda-forge-pinning 2024.11.08.21.03.17
avoid picking up ambient python from somewhere else in the image LAPACK_TESTING_USE_PYTHON only landed in 3.12, see Reference-LAPACK/lapack@d8f668c
…nda-forge-pinning 2024.11.08.21.03.17
Builds on #96; testing if this helps with the MKL failures, see conda-forge/intel_repack-feedstock#44