Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove version restriction #3

Closed
wants to merge 4 commits into from
Closed

Conversation

melund
Copy link
Contributor

@melund melund commented Jan 14, 2020

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@melund
Copy link
Contributor Author

melund commented Jan 14, 2020

@conda-forge-admin, please rerender

@melund
Copy link
Contributor Author

melund commented Jan 14, 2020

@jjnurminen It didn't seem to work. I will just try to remove the python3 patch when building on 2.7.

@melund
Copy link
Contributor Author

melund commented Jan 14, 2020

@jjnurminen It fails with a CMAKE problem. I guess it can be solved, but I don't have time :)

CMake Error at D:/bld/btk_1579008878392/_build_env/Library/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
  Could NOT find NumPy (missing: NUMPY_VERSION NUMPY_INCLUDE_DIR)
Call Stack (most recent call first):
  D:/bld/btk_1579008878392/_build_env/Library/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:393 (_FPHSA_FAILURE_MESSAGE)
  CMake/FindNumPy.cmake:31 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  Wrapping/Python/CMakeLists.txt:4 (FIND_PACKAGE)

@jjnurminen
Copy link

Ok, thanks a lot for your efforts. Maybe I'll dig into it at some point.

@melund melund closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants