Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use glibc 2.17 again #43

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Use glibc 2.17 again #43

merged 3 commits into from
Nov 24, 2024

Conversation

h-vetinari
Copy link
Member

We hadn't documented in #38 why we moved to 2.28, and I forgot the reason (also, the CI logs are no longer there). So double-check what goes wrong with 2.17.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 24, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11994601742. Examine the logs at this URL for more detail.

@h-vetinari h-vetinari changed the title Try glibc 2.17 again Use glibc 2.17 again Nov 24, 2024
@h-vetinari h-vetinari marked this pull request as ready for review November 24, 2024 06:32
@h-vetinari
Copy link
Member Author

@xhochy, I don't remember why you increased the c_stdlib_version in #38, but it seems to work fine with 2.17 as well? Could you PTAL? This would make things a bit easier for pyarrow.

@xhochy
Copy link
Member

xhochy commented Nov 24, 2024

There was a missing symbol in the sysroot headers that got added after 2.17. Seems like they removed the dependency again.

@xhochy
Copy link
Member

xhochy commented Nov 24, 2024

This needs a build no bump.

@h-vetinari
Copy link
Member Author

There was a missing symbol in the sysroot headers that got added after 2.17. Seems like they removed the dependency again.

OK cool! Let's merge this to unblock pyarrow and jaxlib. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants