Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] CUDA installation fixes, add 11.1 and document absence of nvcuda.dll #131

Merged
merged 16 commits into from
Dec 28, 2020

Conversation

jaimergp
Copy link
Member

@jaimergp jaimergp commented Nov 11, 2020

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

I have been trying to provide nvcuda.dll in conda-forge/openmm-feedstock#36 only to realize it is not possible, so I am documenting it here in case somebody wants to try again.

  • The CUDA toolkit installer is supposed to provide the drivers too, but it will silently fail to do that if no GPU is present
  • I thought that maybe getting the Tesla/datacenter drivers would allow a GPU-less install. Well, it's not the case.
  • Old versions of the drivers allowed to manually extract nvcuda64.dl_ into C:\Windows\system32 as nvcuda.dll, but that doesn't seem to be the case with most recent ones -- DLL will fail to load with error 193.

Basically the only way to provide nvcuda.dll involves breaking the EULA since you would have to redistribute the DLL from a working installation to bypass the hardware checks, and we can't do that.

Since I had to experiment with a few things to arrive to this conclusion, I am also adding a few fixes:

  • Enable path to CUDA 11.1 (coming soon)
  • Make sure we wait for the installers to finish!
  • Install only the needed components (no samples, documentation, etc) to save time and space
  • Make sure the CUDA failures are reflected as such in the CI status

Status

@jaimergp jaimergp requested a review from a team as a code owner November 11, 2020 09:28
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jaimergp
Copy link
Member Author

@conda-forge/core we need this for CUDA 11.1, now merged. How should I proceed here? Merge master? Rebase? New PR?

recipe/meta.yaml Outdated Show resolved Hide resolved
@beckermr
Copy link
Member

Resolve the conflicts and make sure the version is ahead. Then we should be good to go.

@beckermr
Copy link
Member

@conda-forge-admin rerender

Just to make sure the merge went ok.

@beckermr
Copy link
Member

Note this won't build for travis. Also, we might want some code review from someone more knowledgeable than me on the CI setup package itself. cc @conda-forge/core

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like I wasn't able to push to the windows-cuda-driver
branch of jaimergp-feedstocks/conda-forge-ci-setup-feedstock. Did you check the "Allow edits from maintainers" box?

@jaimergp
Copy link
Member Author

I also forgot I need to add the CUDA 11.1 matrix entries, which will fail on Linux due to the missing Docker image (see conda-forge/docker-images#160).

@beckermr
Copy link
Member

Can you fork to a non-org place? That way others can rerender.

@jaimergp
Copy link
Member Author

Can you fork to a non-org place? That way others can rerender.

Oops, I didn't know that was a limitation. I'll transfer back to my personal account.

@jaimergp jaimergp changed the title Enable CUDA 11.1, document the absence of nvcuda.dll and other small improvements [Windows] Enable CUDA 11.1, document the absence of nvcuda.dll and other small improvements Nov 22, 2020
@jakirkham
Copy link
Member

It is. Though one can also re-render locally.

@jaimergp jaimergp changed the title [Windows] Enable CUDA 11.1, document the absence of nvcuda.dll and other small improvements [Windows] CUDA installation fixes, add 11.1 and document absence of nvcuda.dll Nov 27, 2020
@jaimergp
Copy link
Member Author

@conda-forge/core this is ready for review!

@jaimergp
Copy link
Member Author

May I ask for a merge if nobody is against it? 😄

@isuruf isuruf merged commit 43bd7da into conda-forge:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants