Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross cuda CI #236

Closed
wants to merge 5 commits into from
Closed

Conversation

h-vetinari
Copy link
Member

Follow-up to #234 & #235, trying to add CI that exercises cross_compile_support.sh - even though we don't exactly need those packages for the infra to run, I think it's better to have them tested on the feedstock of their origin.

@h-vetinari h-vetinari requested a review from a team as a code owner April 18, 2023 20:38
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

CC @isuruf, this would have caught the typo in #234; WDYT about some extra CI?

Copy link

@varlackc varlackc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-vetinari
Copy link
Member Author

Note: I'm aware that we don't need the CUDA12 and CUDA cross-compilation builds here for our infrastructure to run. But we're not testing those setups here currently, which is what this PR is suggesting to add (especially now that we dropped the CUDA 12 builds).

@h-vetinari
Copy link
Member Author

This was essentially done by #261 now. Having cuda 12 jobs is less relevant because https://github.com/conda-forge/conda-forge-ci-setup-feedstock/blob/main/recipe/cross_compile_support.sh doesn't do much for that version.

@h-vetinari h-vetinari closed this Sep 1, 2023
@h-vetinari h-vetinari deleted the cross_cuda_ci branch September 1, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants