Depend on upstream ruamel.yaml instead of unmaintained ruamel_yaml #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
mbargull
commented
Nov 1, 2023
Comment on lines
+12
to
+20
| def get_yaml_safe(): | ||
| # define global yaml API | ||
| # safe-loader and allowing duplicate keys | ||
| # for handling # [filter] / # [not filter] | ||
| # Don't use a global variable for this as a global | ||
| # variable will make conda-smithy thread unsafe. | ||
| yaml = YAML(typ="safe") | ||
| yaml.allow_duplicate_keys = True | ||
| return yaml |
There was a problem hiding this comment.
This is just copy-pasta from conda-smithy.utils.get_yaml with roundtrip-loader exchanged with safe-loader.
YAML requires unique keys, but PyYAML only warns instead of raising errors; allow_duplicate_keys = True is for compatibility with PyYAML. I don't know if we need it here though (IMO, error would be better).
mbargull
commented
Nov 1, 2023
recipe/meta.yaml
Outdated
| @@ -73,7 +73,7 @@ requirements: | |||
| - shyaml | |||
| - jq # [unix] | |||
| - requests | |||
| - ruamel_yaml | |||
| - ruamel.yaml | |||
There was a problem hiding this comment.
Suggested change
| - ruamel.yaml | |
| - ruamel.yaml <0.19.0a0 |
would probably make sense. (No idea about what lower bound would be needed.)
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
…nda-forge-pinning 2023.11.10.18.46.05 Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
mbargull
force-pushed
the
ruamel.yaml
branch
from
dc509ee
to
97b5360
Compare
jaimergp
reviewed
Apr 3, 2024
| @@ -1,5 +1,5 @@ | |||
| {% set name = "conda-forge-ci-setup" %} | |||
| {% set version = "4.1.0" %} | |||
| {% set version = "4.1.1" %} | |||
There was a problem hiding this comment.
Suggested change
| {% set version = "4.1.1" %} | |
| {% set version = "4.3.4" %} |
|
@mbargull This LGTM. Should we try to land it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)I'm currently looking at what packages on conda-forge have a dependency on the non-maintained
ruamel_yamlpackage.