Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generally enable CUDA 12 cross-compilation #363

Closed

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Oct 30, 2024

As CUDA 12 uses standard conda-forge images and ships a CUDA Toolkit enabled for cross-compilation, there is no need to check for CDT_NAME in the CUDA 12 check. Any value conda-forge otherwise supports should also apply to CUDA 12.

CUDA 11 still requires special handling. Though this is not changed here.


Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jakirkham
Copy link
Member Author

@conda-forge/core this is ready for review! 😄

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't yet do what you want. That whole branch is under

if [[ "${CUDA_COMPILER_VERSION}" == "11.2" || "${CUDA_COMPILER_VERSION}" == "11.8" ]] && [[ "${CDT_NAME}" == "cos8" || "${CDT_NAME}" == "cos7" ]]; then
# We use cdt_name=cos7 for rhel8 based nvcc till we figure out
# a stable cos8 replacement.

which needs adaptation as well e.g. cdt_name in ["conda", "cos7"].

I'd also prefer to fully drop CUDA 11.2 from the setup here. We've dropped it half a year ago, so no need to carry this cruft around anymore IMO.

@@ -144,12 +144,9 @@ if [[ "${HOST_PLATFORM}" != "${BUILD_PLATFORM}" ]]; then
elif [[ "${CUDA_COMPILER_VERSION}" == "11.8" ]]; then
echo "cross compiling with cuda == 11.8 and cdt != cos7/8 not supported yet"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is then also outdated.

# No extra steps necessary for CUDA 12, handled through new packages
true
elif [[ "${CUDA_COMPILER_VERSION}" == 12* ]]; then
echo 'cross compiling with cuda == 12.* and cdt != cos7 not supported yet'
exit 1
elif [[ "${CUDA_COMPILER_VERSION}" != "None" ]]; then
echo 'cross compiling with cuda not in (11.2, 11.8, 12.*) not supported yet'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@jakirkham
Copy link
Member Author

Closing as this appears to be addressed by PR: #365

@jakirkham jakirkham closed this Nov 22, 2024
@jakirkham jakirkham deleted the simp_cuda12_cross branch November 22, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants