-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CUDA 12.0 migrator. #4400
Add CUDA 12.0 migrator. #4400
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Bradley! 🙏
Added a few suggestions below 🙂
Went ahead and submitted PR ( #4407 ) to add Edit: That PR has now been merged. Have updated the branch here to include those changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Included a few suggestions below to simplify things (now that some changes have been moved to conda_build_config.yaml
)
Better matches the CUDA 12 migrator naming.
Adding this for testing purposes. This needs to be dropped after. Add comments to remind us to remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added use_local
lines to simplify testing. Flagging them as a reminder to remove them
These were pulling in CentOS 6 instead of CentOS 7 images as observed by Leo. Include his fix for using CentOS 7 images.
158c60d
to
e81f62c
Compare
e81f62c
to
cc39d20
Compare
Just a note, retested the latest changes here on NCCL, UCX & CuPy. They behaved as expected (equivalent to the current CUDA 12 state for each of those) |
Focusing on CUDA 12.0 `x86_64` initially.
Sounds like we are ok with starting this based on discussion in the core meeting. Going to go ahead and merge. Happy to follow up on anything as needed. Thanks all! 🙏 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)This PR adds a migrator for CUDA 12 support. The compiler package name is changing from
nvcc
tocuda-nvcc
, socuda_compiler
must be added tozip_keys
. CUDA 12 builds should use gcc/g++ version 12, and they do not need a special CUDA Docker image (the normal Docker image is sufficient).This is my first time submitting a migrator, so please forgive any egregious mistakes! I'm starting this as a draft and getting some input before opening for review. cc: @jakirkham @leofang @adibbley @vyasr