-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In no CUDA case, set cuda*
variables undefined
#4534
base: main
Are you sure you want to change the base?
In no CUDA case, set cuda*
variables undefined
#4534
Conversation
Instead of setting `cuda*` variables to `None` in the no CUDA (CPU case), set them to `undefined`. This works better with Jinja filters (`|`), which makes it easier to work with.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I think that would make things like |
Well said! IIUC think it would be using Just to contextualize this, a line like this... - libcublas-dev # [(cuda_compiler_version or "").startswith("12")] ...could become... - libcublas-dev # [cuda_compiler_version|startswith("12")] |
I forgot, one other foot gun is that if anyone is treating I am all for this change, just trying to enumerate some of the edge cases that will make people grumpy when their feedstocks get busted. |
Yeah think the main issue is when recipes compare to |
For me as a feedstock maintainer, if the migration bot for this included an explanation of what changed, and a few examples on how to migrate, I think it would be helpful. But since this isn't a migration, I think people will re-render and not get any explanation on what changed and will just be confused. |
That's true we could put this in a migrator instead. Also could include a custom commit message with a detail about what changed |
I think that would be better so there is less of a rug pull |
It's worth noting the migrator PR title is taken from the first line of the commit message so we can make this change pretty visible |
Instead of setting
cuda*
variables toNone
in the no CUDA (CPU case), set them toundefined
. This works better with Jinja filters (|
), which makes it easier to work with.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)