Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin: Add flexparser upper bound #900

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

ndevenish
Copy link
Contributor

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

show_diff output:

================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
win-32
================================================================================
================================================================================
linux-ppc64le
================================================================================
================================================================================
osx-arm64
================================================================================
================================================================================
linux-aarch64
================================================================================
================================================================================
noarch
noarch::pint-0.24.1-pyhd8ed1ab_0.conda
noarch::pint-0.24.1-pyhd8ed1ab_1.conda
noarch::pint-0.24.3-pyhd8ed1ab_0.conda
-    "flexparser >=0.3",
+    "flexparser >=0.3,<0.4",
================================================================================
================================================================================
win-64
================================================================================
================================================================================
osx-64
================================================================================
================================================================================
linux-64

See conda-forge/pint-feedstock#71 and upstream comments; flexparser=0.4 broke with older pint versions. I've only patched 0.24.* here because that's when the flexparser >=0.3 constraint was added.

@ndevenish ndevenish requested a review from a team as a code owner November 7, 2024 12:51
@ndevenish ndevenish changed the title Pint flexparser Pin: Add flexparser upper bound Nov 7, 2024
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@dopplershift dopplershift merged commit 97198d4 into conda-forge:main Nov 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants