-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit python and xarray version for imod<=0.18.1 #925
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
You need to fix that in the feedstock first, or the next build will also require a patch. See https://github.com/conda-forge/imod-feedstock/blob/main/recipe/meta.yaml#L57 |
Thanks for the fast response, I didn't read the docs carefully enough so I missed that I had to update the feedstock recipe for future releases, but that makes complete sense. I've created a new build on the feedstock which is now merged. conda-forge/imod-feedstock#44 . Is that sufficient to merge this PR and get the older versions patched as well? |
That is up to you. For "correctness" one could patch everything that is affected. However, we usually patch only the most used one/latest to avoid over patching. |
Ah yes, good to see you are pragmatic about patching. Thanks for the quick response again and the merge! |
Checklist
generate_patch_json.py
if absolutely necessary.pre-commit run -a
and ensured all files pass the linting checks.python show_diff.py
and posted the output as part of the PR.Results show diff: