Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Replace minimum required Python for scikit-hep-testdata v0.5.0. #928

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Dec 15, 2024

$ python -c "import datetime; print(f'{datetime.datetime(2024,11,21).timestamp():.0f}000')"
1732172400000

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • [N/A] Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
$ micromamba env create --yes --file recipe/dev-env-for-patches.yaml
$ micromamba activate repodata-patches
$ python recipe/show_diff.py
================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
win-32
================================================================================
================================================================================
linux-ppc64le
================================================================================
================================================================================
osx-arm64
================================================================================
================================================================================
linux-aarch64
================================================================================
================================================================================
noarch
noarch::scikit-hep-testdata-0.5.0-pyhd8ed1ab_0.conda
-    "python >=3.8",
+    "python >=3.9",
================================================================================
================================================================================
win-64
================================================================================
================================================================================
osx-64
================================================================================
================================================================================
linux-64
  • Modifications won't affect packages built in the future.

Used 2024-11-21 (the day after the fix was merged) as cut off date:

$ python -c "import datetime; print(f'{datetime.datetime(2024,11,21).timestamp():.0f}000')" 
1732172400000

* https://github.com/conda-forge/scikit-hep-testdata-feedstock has broken
metadata for package scikit-hep-testdata-0.5.0-pyhd8ed1ab_0.conda.
(https://anaconda.org/conda-forge/scikit-hep-testdata/files?version=0.5.0)
The package has a 'run' requirement of python >=3.8 but scikit-hep-testdata
v0.5.0 dropped 3.8 support and is Python 3.9+. This was fixed in
https://github.com/conda-forge/scikit-hep-testdata-feedstock PR 68 on
2024-11-20, so use 1732172400000 (2024-11-21 in human readable metadata)
as the cutoff timestamp.

$ python -c "import datetime; print(f'{datetime.datetime(2024,11,21).timestamp():.0f}000')"
1732172400000
@matthewfeickert matthewfeickert requested a review from a team as a code owner December 15, 2024 03:35
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@xhochy xhochy merged commit 1c902ce into conda-forge:main Dec 15, 2024
3 checks passed
@matthewfeickert matthewfeickert deleted the fix/update-min-python-scikit-hep-testdata branch December 15, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants