Add announcement for clang support across platforms #2161
Conversation
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| ``` | ||
| # please consult @conda-forge/core before doing this | ||
| c_compiler: | ||
| - clang |
There was a problem hiding this comment.
Open to add something like this:
| - clang | |
| # look ma, no selectors! | |
| - clang |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Co-Authored-By: jaimergp <jaimergp@users.noreply.github.com>
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
news/2024-04-30-clang-everywhere.md
Outdated
| `recipe/conda_build_config.yaml`: | ||
|
|
||
| ```yaml | ||
| # please consult @conda-forge/core before doing this |
There was a problem hiding this comment.
My thinking was that we don't (yet?) want to make it a free-for-all for feedstocks to choose their compilers. I think the cautious choice would be to keep feedstocks on the default compilers unless there are good reasons for choosing clang, at least while we get some more experience with using clang on linux/win.
That line was meant as a kind of natural "brake" on people's enthusiasm in order to have a softer rollout, but if you feel that this caution is not necessary, I can remove that line.
There was a problem hiding this comment.
My feeling is that people that choose clang as compiler either know what they are doing and thus don't need to spam core with more notifications or they are doing it as part of a copy/paste from another recipe, fail to apply it and will ping someone competent anyways. Thus, for the sake of a bit less notifications, I would omit it.
There was a problem hiding this comment.
@isuruf, I'm assuming your concern here is addressed now?
Co-authored-by: Mervin Fansler <mmfansler@gmail.com>
This fleshes out a skeleton that wrongly got committed in e470f0d - sorry about that.
I had wanted to wait for conda-forge/clang-win-activation-feedstock#34 to land and then raise a PR. @jaimergp kindly pointed out that this slipped in elsewhere.
Relevant xref: conda-forge/ctng-compiler-activation-feedstock#102