refactor build_with_mambabuild bool with conda_build_tool choice #1732
Conversation
…-build-tool-choices
|
A few DNM PRs to test this live:
Edit: Interestingly, all Windows builds reported an exit code of 1 despite having passed the build and tests successfully 🤔 |
|
Think it might help for us to ship Maybe this simplifies the install commands (or even removes the need for them) |
| set "CONDA_SOLVER=libmamba" | ||
| conda.exe build "{{ recipe_dir }}" -m .ci_support\%CONFIG%.yaml --suppress-variables %EXTRA_CB_OPTIONS% |
There was a problem hiding this comment.
Would it makes sense to either specify this by the --solver flag or better yet add this to the .condarc
There was a problem hiding this comment.
conda-build doesn't have the --solver flag so the other alternative is writing to .condarc, but that will have global impact on the other uses of conda so I initially wanted to constrain the scope as much as possible (in case something breaks).
I am happy to revisit that in the future as we debug it step by step.
|
Thanks Jaime! 🙏 Had a couple questions above |
|
The strange Windows exit_code=1 issues are gone if we use conda 23.7 and conda-build 3.26 🤷 |
|
LGTM! |
Checklist
newsentryRefactoring the
build_with_mambabuildboolean option with a more future-proofconda_build_tool"list of choices". I have added support for:mambabuildconda-buildwithconda-libmamba-solverconda-buildwith (forced)classicsolverconda-build(no specific solver configuration)In a hypothetical future, this setup would also allow us to have
boaandrattler-build, for example.build_with_mambabuild=Truemaps toconda_build_tool=mambabuild. Thefalseequivalent maps toconda_build_tool=conda-build.Note that the default behaviour (using
mambabuild) has not changed.Why this change now?
This just adds opt-in support for conda-libmamba-solver. I am working on improving the integration with conda-build in conda/conda-libmamba-solver#194. While the current released implementation works for single output recipes, I think it might not work correctly with multi-output stuff, or maybe with multi-recipe calls.